build,win: open shortcut folder instead of running script

[refack]

An alternative UX idea:
At the end of the installer open the created Shortcut dir, where the users can explicitly call the new Install Additional Tools for Node.js shortcut.
Refs: #22645
Fixes: #23838

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[nodejs-github-bot]

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1534/pipeline

[joaocgreis]

What is the point of this? Users already opted in by checking the checkbox, and there is plenty of opportunity to stop it before it starts the package installation.

[refack]

What is the point of this?

Pure UX.
After talking with some users, and seeking the advice of friends that work on improving UX, this was the recommendation. The idea is that installer check boxes are ignored, and users will associate the action with the installer.
Explicitly invoking the install script will make users aware of this specific action, and associates the consequences with the script and not the installer.

Even if this doesn't solve the issue, I would strongly suggest we continue iterating on this issue.

I'm flagging this as a regression because of all the negative user feedback 🤷‍♂️

[refack]

/CC @nodejs/build-files @nodejs/platform-windows @nodejs/UX ;)

[joaocgreis]

Good point, to make it clear that it's a different thing.

Test build: https://nodejs.org/download/test/v12.0.0-test20181108dab27c03ea/

[refack]

The output MSI
node-v12.0.0-test20181108dab27c03ea-x64.zip

[refack]

Well it doesn't like my HTML :(

[richardlau]

Well it doesn't like my HTML :(

Also looks to have a whitespace issue between modules, and some tools.

[refack]

Ok GUI looks as expected, but I can't seem to get the folder to open...

[Trott]

@refack Is this still being worked on?