Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process: move environment variable proxy code into node_env_var.cc #25067

Closed
wants to merge 1 commit into from
Closed

process: move environment variable proxy code into node_env_var.cc #25067

wants to merge 1 commit into from

Commits on Dec 15, 2018

  1. process: move environment variable proxy code into node_env_var.cc 

    Instead of exposing all the NamedPropertyHandlerConfiguration()
parameters in node_internals, simply expose a CreateEnvVarProxy()
method that returns a Local<Value> that implements process.env,
and mark all the property handlers static in node_env_var.cc.
This makes the code more encapsulated.
    @joyeecheung
    joyeecheung committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    a1f09b0 View commit details
    Browse the repository at this point in the history