New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: use std::vector for setting up process.execPath #25069

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
9 participants
@addaleax
Copy link
Member

addaleax commented Dec 15, 2018

Whitespace-adjusted diff for review: https://github.com/nodejs/node/pull/25069/files?w=1

Use std::vector as an RAII-style alternative to allocating
and deleting raw memory storage.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
src: use std::vector for setting up process.execPath
Use `std::vector` as an RAII-style alternative to allocating
and deleting raw memory storage.
@richardlau

This comment has been minimized.

Copy link
Member

richardlau commented Dec 15, 2018

Commit message linter failure is bogus. Have opened nodejs/core-validate-commit#40.

@lpinca

lpinca approved these changes Dec 16, 2018

@TimothyGu

This comment has been minimized.

Copy link
Member

TimothyGu commented Dec 17, 2018

Is there a reason why we can't statically allocate the memory, given that PATH_MAX is known at compile-time?

@danbev

This comment has been minimized.

Copy link
Member

danbev commented Dec 20, 2018

@danbev

This comment has been minimized.

Copy link
Member

danbev commented Dec 21, 2018

Landed in 0461e4c.

@danbev danbev closed this Dec 21, 2018

pull bot pushed a commit to Rachelmorrell/node that referenced this pull request Dec 21, 2018

src: use std::vector for setting up process.execPath
Use `std::vector` as an RAII-style alternative to allocating
and deleting raw memory storage.

PR-URL: nodejs#25069
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 25, 2018

src: use std::vector for setting up process.execPath
Use `std::vector` as an RAII-style alternative to allocating
and deleting raw memory storage.

PR-URL: #25069
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 25, 2018

Merged

v11.6.0 proposal #25175

MylesBorins added a commit that referenced this pull request Dec 26, 2018

src: use std::vector for setting up process.execPath
Use `std::vector` as an RAII-style alternative to allocating
and deleting raw memory storage.

PR-URL: #25069
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

src: use std::vector for setting up process.execPath
Use `std::vector` as an RAII-style alternative to allocating
and deleting raw memory storage.

PR-URL: nodejs#25069
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment