New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report: represent numbers as numbers #25651

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
8 participants
@addaleax
Copy link
Member

addaleax commented Jan 22, 2019

report: refactor JSON writer

  • Support non-string entry types
  • Prefer single-character writes over string writes
  • Rename the state constants and adjust style to match more common Node.js style

report: represent numbers as numbers

Do not stringify numbers and boolean values when writing JSON.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

addaleax added some commits Jan 22, 2019

report: refactor JSON writer
- Support non-string entry types
- Prefer single-character writes over string writes
- Rename the state constants and adjust style to match more
  common Node.js style
report: represent numbers as numbers
Do not stringify numbers and boolean values when writing JSON.

@addaleax addaleax added the report label Jan 22, 2019

@addaleax addaleax requested review from cjihrig and gireeshpunathil Jan 22, 2019

@addaleax

This comment has been minimized.

Copy link
Member Author

addaleax commented Jan 24, 2019

@addaleax

This comment has been minimized.

Copy link
Member Author

addaleax commented Jan 24, 2019

@mhdawson
Copy link
Member

mhdawson left a comment

LGTM

@addaleax

This comment has been minimized.

Copy link
Member Author

addaleax commented Jan 25, 2019

@addaleax

This comment has been minimized.

Copy link
Member Author

addaleax commented Jan 27, 2019

@addaleax

This comment has been minimized.

Copy link
Member Author

addaleax commented Jan 27, 2019

Sigh… let’s try a fresh full CI: https://ci.nodejs.org/job/node-test-pull-request/20353/

@addaleax

This comment has been minimized.

Copy link
Member Author

addaleax commented Jan 27, 2019

Landed in 08e9111, accd674

@addaleax addaleax closed this Jan 27, 2019

@addaleax addaleax deleted the addaleax:report-numbers branch Jan 27, 2019

addaleax added a commit that referenced this pull request Jan 27, 2019

report: refactor JSON writer
- Support non-string entry types
- Prefer single-character writes over string writes
- Rename the state constants and adjust style to match more
  common Node.js style

PR-URL: #25651
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

addaleax added a commit that referenced this pull request Jan 27, 2019

report: represent numbers as numbers
Do not stringify numbers and boolean values when writing JSON.

PR-URL: #25651
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

addaleax added a commit that referenced this pull request Jan 28, 2019

report: refactor JSON writer
- Support non-string entry types
- Prefer single-character writes over string writes
- Rename the state constants and adjust style to match more
  common Node.js style

PR-URL: #25651
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

addaleax added a commit that referenced this pull request Jan 28, 2019

report: represent numbers as numbers
Do not stringify numbers and boolean values when writing JSON.

PR-URL: #25651
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@targos targos referenced this pull request Jan 29, 2019

Merged

v11.9.0 proposal #25802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment