New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove unused and unimplemented method in env.h #25699

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@gengjiawen
Copy link
Contributor

gengjiawen commented Jan 25, 2019

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
src: remove unused and unimplemented method in env.h
Signed-off-by: gengjiawen <technicalcute@gmail.com>
@addaleax

This comment has been minimized.

@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Jan 27, 2019

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Jan 28, 2019

@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Jan 28, 2019

Landed in dc843f5

@addaleax addaleax closed this Jan 28, 2019

addaleax added a commit that referenced this pull request Jan 28, 2019

src: remove unused and unimplemented method in env.h
Signed-off-by: gengjiawen <technicalcute@gmail.com>

PR-URL: #25699
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax added a commit that referenced this pull request Jan 28, 2019

src: remove unused and unimplemented method in env.h
Signed-off-by: gengjiawen <technicalcute@gmail.com>

PR-URL: #25699
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@targos targos referenced this pull request Jan 29, 2019

Merged

v11.9.0 proposal #25802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment