Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "build: silence cpp lint by default" #26358

Merged
merged 1 commit into from Mar 7, 2019

Conversation

@refack
Copy link
Member

commented Feb 28, 2019

This reverts commit 0373836.

PR effect is semver major, and removes an escape hatch.
This landed without proper review from @nodejs/build-files

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@refack refack requested a review from BridgeAR Feb 28, 2019

@refack

This comment has been minimized.

Copy link
Member Author

commented Feb 28, 2019

IIUC the original intent was to change

node/Makefile

Lines 57 to 60 in 0373836

# Default to verbose builds.
# To do quiet/pretty builds, run `make V=` to set V to an empty string,
# or set the V environment variable to an empty string.
V ?= 1

@refack refack self-assigned this Feb 28, 2019

@refack refack added the fast-track label Feb 28, 2019

@refack refack requested review from danbev and jasnell Feb 28, 2019

@BridgeAR

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

@refack the regular cpp linting output is super verbose. This does not seem to be a good default. And in what way is the behavior semver-major? Do we count the output of our makefile towards semver-major?

I guess ideally, we'd have an opt-in to get the verbose cpp linting output.

@BridgeAR BridgeAR removed the fast-track label Mar 3, 2019

@danbev

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

I would prefer to make lint-cpp quiet by default as it does not really provide any information except that what files it is processing. I understand that this is possible using the verbose flag but at least I personally don't use it very often.

I don't want to block this as there are already approvals so I'm going to remove myself from the reviews list.

@danbev danbev removed their request for review Mar 7, 2019

@joyeecheung

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

Why is the effect semver-major?

@refack

This comment has been minimized.

Copy link
Member Author

commented Mar 7, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21315/

Why is the effect semver-major?

And in what way is the behavior semver-major?

  1. Output of the build process is semver-major for downstream embedders (and you CI scripts).
  2. In principal the Makefile should be able to output full logs for tracing & debugging. The reverted commit disabled any way of getting that output.
  3. I'd be +1 on changing

    node/Makefile

    Lines 57 to 60 in 0373836

    # Default to verbose builds.
    # To do quiet/pretty builds, run `make V=` to set V to an empty string,
    # or set the V environment variable to an empty string.
    V ?= 1

    In the meantime make V=0 should work just fine.
@refack

This comment has been minimized.

Copy link
Member Author

commented Mar 7, 2019

P.S. the lint-cpp target is timestamp aware. So only files changed should show up in the default output.

Revert "build: silence cpp lint by default"
This reverts commit 0373836.

PR-URL: #26358
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@refack refack force-pushed the refack:revert-0373836 branch from 66b88f9 to 91e1a04 Mar 7, 2019

@refack refack merged commit 91e1a04 into nodejs:master Mar 7, 2019

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details

@refack refack deleted the refack:revert-0373836 branch Mar 8, 2019

@refack refack removed their assignment Mar 11, 2019

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
Revert "build: silence cpp lint by default"
This reverts commit 0373836.

PR-URL: nodejs#26358
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR added a commit that referenced this pull request Mar 14, 2019
Revert "build: silence cpp lint by default"
This reverts commit 0373836.

PR-URL: #26358
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.