Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark `test-worker-prof` as Flaky on ARM #26557

Merged
merged 1 commit into from Mar 10, 2019

Conversation

@refack
Copy link
Member

commented Mar 10, 2019

Refs: #26401

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@refack

This comment has been minimized.

Copy link
Member Author

commented Mar 10, 2019

If this passes CI, I move we fast-tack this.
CI: https://ci.nodejs.org/job/node-test-pull-request/21384/

@refack

This comment has been minimized.

Copy link
Member Author

commented Mar 10, 2019

@Trott
Trott approved these changes Mar 10, 2019

@Trott Trott added the author ready label Mar 10, 2019

test: mark `test-worker-prof` as Flaky on ARM
PR-URL: #26557
Refs: #26401
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@refack refack force-pushed the refack:flake-test-worker-prof branch from 8a690b4 to 8d665c0 Mar 10, 2019

@refack refack merged commit 8d665c0 into nodejs:master Mar 10, 2019

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details

@refack refack deleted the refack:flake-test-worker-prof branch Mar 10, 2019

BridgeAR added a commit that referenced this pull request Mar 13, 2019
test: mark `test-worker-prof` as Flaky on ARM
PR-URL: #26557
Refs: #26401
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR added a commit that referenced this pull request Mar 13, 2019
test: mark `test-worker-prof` as Flaky on ARM
PR-URL: #26557
Refs: #26401
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR added a commit that referenced this pull request Mar 14, 2019
test: mark `test-worker-prof` as Flaky on ARM
PR-URL: #26557
Refs: #26401
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs added a commit that referenced this pull request Apr 16, 2019
test: mark `test-worker-prof` as Flaky on ARM
PR-URL: #26557
Refs: #26401
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.