Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove old system_errors #27037

Merged
merged 1 commit into from
Apr 3, 2019
Merged

doc: remove old system_errors #27037

merged 1 commit into from
Apr 3, 2019

Conversation

JungMinu
Copy link
Member

@JungMinu JungMinu commented Apr 1, 2019

  • remove old errors_system_errors which partially predate the existence of the class, any useful information in it moved into the SystemError class docs
  • outdent SystemError class docs to the same level as all the other classes
Checklist

@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3130

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 1, 2019
@JungMinu JungMinu requested a review from sam-github April 1, 2019 01:54
@JungMinu
doc: remove old system_errors
e02f511 
Remove old errors_system_errors, any useful information
in it moved into the SystemError class docs.

Fixes: #26861
PR-URL: #27037
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
@JungMinu JungMinu merged commit e02f511 into nodejs:master Apr 3, 2019
@JungMinu JungMinu deleted the doc branch April 3, 2019 00:44
@vsemozhetbyt vsemozhetbyt mentioned this pull request Apr 3, 2019
Closed
3 tasks
BethGriggs pushed a commit that referenced this pull request Apr 4, 2019
@JungMinu @BethGriggs
doc: remove old system_errors
d0bd104 
Remove old errors_system_errors, any useful information
in it moved into the SystemError class docs.

Fixes: #26861
PR-URL: #27037
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 9, 2019
@JungMinu @BethGriggs
doc: remove old system_errors
a5314a1 
Remove old errors_system_errors, any useful information
in it moved into the SystemError class docs.

Fixes: #26861
PR-URL: #27037
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Apr 9, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 10, 2019
@JungMinu @BethGriggs
doc: remove old system_errors
316372c 
Remove old errors_system_errors, any useful information
in it moved into the SystemError class docs.

Fixes: #26861
PR-URL: #27037
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-github sam-github sam-github approved these changes

@mihalskiy mihalskiy mihalskiy approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JungMinu @nodejs-github-bot @sam-github @mihalskiy