Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: document trace-events category for dns requests #28100

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@vmarchaud
Copy link
Contributor

commented Jun 6, 2019

As implemented in #21840, dns can
emit trace events when the category is enabled. This PR just add
it to the documentation.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@cjihrig

cjihrig approved these changes Jun 6, 2019

Show resolved Hide resolved doc/api/tracing.md Outdated
@Trott

Trott approved these changes Jun 6, 2019

Copy link
Member

left a comment

LGTM with or without my minor suggestion

doc: document trace-events category for dns requests
As implemented in #21840, dns can
emit trace events when the category is enabled. This PR just add
it to the documentation.

@vmarchaud vmarchaud force-pushed the vmarchaud:trace_events_dns branch from d1a5e26 to bfeb47e Jun 7, 2019

@Trott

This comment has been minimized.

@Trott Trott added the author ready label Jun 10, 2019

@Trott

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

Landed in f7ffa52

@Trott Trott closed this Jun 13, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jun 13, 2019

doc: document trace-events category for dns requests
As implemented in nodejs#21840, dns can
emit trace events when the category is enabled. This PR just add
it to the documentation.

PR-URL: nodejs#28100
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@vmarchaud vmarchaud deleted the vmarchaud:trace_events_dns branch Jun 13, 2019

BridgeAR added a commit that referenced this pull request Jun 17, 2019

doc: document trace-events category for dns requests
As implemented in #21840, dns can
emit trace events when the category is enabled. This PR just add
it to the documentation.

PR-URL: #28100
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@BridgeAR BridgeAR referenced this pull request Jun 17, 2019

Open

v12.5.0 proposal #28268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.