Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: document PerformanceNodeTiming.environment field #28280

Closed
wants to merge 1 commit into from

Conversation

@yvasiyarov
Copy link

commented Jun 18, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@Trott
Copy link
Member

left a comment

Welcome @yvasiyarov and thanks for the pull request! If you look at the other performanceNodeTiming entries, they are in alphabetical order. So instead of putting this one at the end, can you put it in the alphabetized location in the list? Thanks!

@yvasiyarov yvasiyarov force-pushed the yvasiyarov:perf_hook_doc branch from db6244d to 3cb7665 Jun 19, 2019

@yvasiyarov

This comment has been minimized.

Copy link
Author

commented Jun 19, 2019

@Trott fixed. commit squashed with original commit

@cjihrig
Copy link
Contributor

left a comment

LGTM with the sorting nit addressed.

@Trott
Trott approved these changes Jun 20, 2019

@Trott Trott added the author ready label Jun 20, 2019

@Trott

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Jun 21, 2019

Landed in 7334aaf

@Trott Trott closed this Jun 21, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jun 21, 2019
doc: document PerformanceNodeTiming.environment field
PR-URL: nodejs#28280
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member

commented Jun 21, 2019

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

targos added a commit that referenced this pull request Jul 2, 2019
doc: document PerformanceNodeTiming.environment field
PR-URL: #28280
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos referenced this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.