guide: use github name instead of name + addr

[yorkie]

Just a proposal :-)

[mscdex]

Why?

[yorkie]

Actually I'm using Node.js COLLABORATOR_GUIDE in one of my business team, and it works great. But I just found we are using Github, right? So sometimes we could directly call someone via Github comments under the commit not via their emails, then the reviewer would automatically get notification.

Just feel it works better than before in that team, so I hope give a feedback to the upstream, Node.js community, never mind to close this if you think this is impossible to apply :-)

[mscdex]

FWIW I am strongly against using @-style mentions in commit messages just because there is no way to turn off the notifications that you get every time someone pushes a commit (especially in forks) with @yourname in the message. I've already suggested to GitHub support a switch to disable strictly those notifications, but I'm not optimistic about seeing it implemented (at least any time soon)...

[Qard]

I get what you are saying about email noise, but this should only be getting applied after review, before a merge. I don't think it'd actually be that noisy.

I'm indifferent on adding github names, but I'm -1 on removing email.

[yorkie]

Ok....closing, thanks

[mscdex]

@Qard Actually, you get a notification anytime anyone pushes that commit to their fork too. I am not 100% sure about the exact circumstances, but I'm speaking on prior experience here. It can get annoying quick...

[yorkie]

This is my bad, I tend to use Github name just because sometimes workers at that business team are not that strong Github man, so often notification is fine, too. Obviously this doesn't work great for Node.js reviewers team, thank you again @mscdex :-)