Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update README.md to fix active/maint times #30707

Closed
wants to merge 1 commit into from

Conversation

@mhdawson
Copy link
Member

mhdawson commented Nov 28, 2019

Update REAMDE.md to be consistent with the
active/maintenance times (12/18) outlined in
https://github.com/nodejs/Release#release-plan. This was missed
when the times were swapped in the Node.js 12 timeframe.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Update REAMDE.md to be consistent with the
active/maintenance times (12/18) outlined in
https://github.com/nodejs/Release#release-plan. This was missed
when the times were swapped in the Node.js 12 timeframe.
@mhdawson mhdawson force-pushed the mhdawson:readmefix branch from 5b188be to bbb01de Nov 28, 2019
Copy link
Member

MylesBorins left a comment

LGTM

@MylesBorins

This comment has been minimized.

Copy link
Member

MylesBorins commented Nov 28, 2019

we should fast-track

@mhdawson

This comment has been minimized.

Copy link
Member Author

mhdawson commented Nov 28, 2019

@mhdawson

This comment has been minimized.

Copy link
Member Author

mhdawson commented Nov 29, 2019

CI was good and we have enough approves but now bump for the fast-track. I'll plan to land on monday unless somebody beats me to it.

danbev added a commit that referenced this pull request Dec 2, 2019
Update REAMDE.md to be consistent with the
active/maintenance times (12/18) outlined in
https://github.com/nodejs/Release#release-plan. This was missed
when the times were swapped in the Node.js 12 timeframe.

PR-URL: #30707
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@danbev

This comment has been minimized.

Copy link
Member

danbev commented Dec 2, 2019

Landed in 84819b8.

@danbev danbev closed this Dec 2, 2019
targos added a commit that referenced this pull request Dec 2, 2019
Update REAMDE.md to be consistent with the
active/maintenance times (12/18) outlined in
https://github.com/nodejs/Release#release-plan. This was missed
when the times were swapped in the Node.js 12 timeframe.

PR-URL: #30707
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
targos added a commit that referenced this pull request Dec 5, 2019
Update REAMDE.md to be consistent with the
active/maintenance times (12/18) outlined in
https://github.com/nodejs/Release#release-plan. This was missed
when the times were swapped in the Node.js 12 timeframe.

PR-URL: #30707
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Sebastien-Ahkrin added a commit to Sebastien-Ahkrin/node that referenced this pull request Dec 11, 2019
Update REAMDE.md to be consistent with the
active/maintenance times (12/18) outlined in
https://github.com/nodejs/Release#release-plan. This was missed
when the times were swapped in the Node.js 12 timeframe.

PR-URL: nodejs#30707
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins added a commit that referenced this pull request Dec 17, 2019
Update REAMDE.md to be consistent with the
active/maintenance times (12/18) outlined in
https://github.com/nodejs/Release#release-plan. This was missed
when the times were swapped in the Node.js 12 timeframe.

PR-URL: #30707
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
BethGriggs added a commit that referenced this pull request Dec 31, 2019
Update REAMDE.md to be consistent with the
active/maintenance times (12/18) outlined in
https://github.com/nodejs/Release#release-plan. This was missed
when the times were swapped in the Node.js 12 timeframe.

PR-URL: #30707
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.