v14.7.0 proposal

.github/workflows/build-tarball.yml

@@ -1,6 +1,10 @@
 name: Build from tarball
 
-on: [push, pull_request]
+on:
+  pull_request:
+  push:
+    branches:
+      - master
 
 env:
   FLAKY_TESTS: dontcare
@@ -9,7 +13,7 @@ jobs:
   build-tarball:
     env:
       PYTHON_VERSION: 3.8
-    runs-on: macos-latest
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
       - name: Set up Python ${{ env.PYTHON_VERSION }}
@@ -22,8 +26,8 @@ jobs:
         run: |
           export DISTTYPE=nightly
           export DATESTRING=`date "+%Y-%m-%d"`
-          export COMMIT=xxxx
-          ./configure && make tar -j8
+          export COMMIT=$(git rev-parse --short=10 "$GITHUB_SHA")
+          ./configure && make tar -j8 SKIP_XZ=1
           mkdir tarballs
           mv *.tar.gz tarballs
       - name: Upload tarball artifact
@@ -64,78 +68,3 @@ jobs:
         run: |
           cd $TAR_DIR
           make run-ci -j2 V=1 TEST_CI_ARGS="-p dots"
-  test-tarball-windows:
-    needs: build-tarball
-    runs-on: windows-latest
-    steps:
-      - name: Set up autocrlf
-        run: |
-          git config --global core.autocrlf true
-      - uses: actions/checkout@v2
-      - name: Set up Python 3.8
-        uses: actions/setup-python@v2
-        with:
-          python-version: 3.8
-      - name: Environment Information
-        run: npx envinfo
-      - name: Download tarball
-        uses: actions/download-artifact@v1
-        with:
-          name: tarballs
-      - name: Extract tarball
-        run: |
-          7z x tarballs/*.tar.gz
-          7z x *.tar -ttar
-      - name: Install deps
-        run: choco install nasm
-      - name: Build
-        run: |
-          $env:DEBUG_HELPER=1
-          $tarfile = dir *.tar
-          cd $tarfile.BaseName
-          $env:msbuild_args="/binaryLogger:node.binlog"
-          ./vcbuild.bat x64 release msi
-          echo "::set-env name=TAR_DIR::$pwd"
-      - name: Copy out directory to checkout dir
-        run: Move-Item -Path "$env:TAR_DIR\out" -Destination "$env:GITHUB_WORKSPACE"
-      - name: "Test JS Suites"
-        shell: cmd
-        run: |
-          set DEBUG_HELPER=1
-          ./vcbuild.bat release noprojgen nobuild ignore-flaky test-ci-js
-      - name: "Test C++ Suites"
-        shell: cmd
-        run: |
-          set DEBUG_HELPER=1
-          ./vcbuild.bat release noprojgen nobuild ignore-flaky test-ci-native
-  test-tarball-macOS:
-    needs: build-tarball
-    runs-on: macos-latest
-    steps:
-      - uses: actions/checkout@v2
-      - name: Set up Python ${{ env.PYTHON_VERSION }}
-        uses: actions/setup-python@v1
-        with:
-          PYTHON_VERSION: ${{ env.PYTHON_VERSION }}
-      - name: Environment Information
-        run: npx envinfo
-      - name: Download tarball
-        uses: actions/download-artifact@v1
-        with:
-          name: tarballs
-      - name: Extract tarball
-        run: |
-          tar xzf tarballs/*.tar.gz
-          echo "::set-env name=TAR_DIR::`basename tarballs/*.tar.gz .tar.gz`"
-      - name: Copy directories needed for testing
-        run: |
-          cp -r tools/node_modules $TAR_DIR/tools
-          cp -r tools/eslint-rules $TAR_DIR/tools
-      - name: Build
-        run: |
-          cd $TAR_DIR
-          make build-ci -j8 V=1
-      - name: Test
-        run: |
-          cd $TAR_DIR
-          make run-ci -j8 V=1 TEST_CI_ARGS="-p dots"

.github/workflows/build-windows.yml

@@ -1,6 +1,10 @@
 name: build-windows
 
-on: [push, pull_request]
+on:
+  pull_request:
+  push:
+    branches:
+      - master
 
 env:
   PYTHON_VERSION: 3.8

.github/workflows/linters.yml

@@ -1,6 +1,10 @@
 name: linters
 
-on: [push, pull_request]
+on:
+  pull_request:
+  push:
+    branches:
+      - master
 
 env:
   PYTHON_VERSION: 3.8

.github/workflows/misc.yml

@@ -1,6 +1,10 @@
 name: misc
 
-on: [push, pull_request]
+on:
+  pull_request:
+  push:
+    branches:
+      - master
 
 env:
   NODE_VERSION: 12.x

.github/workflows/test-asan.yml

@@ -2,6 +2,8 @@ name: test-asan
 
 on:
   push:
+    branches:
+    - master
     paths-ignore:
     - 'doc/**'
   pull_request:

.github/workflows/test-linux.yml

@@ -1,6 +1,10 @@
 name: test-linux
 
-on: [push, pull_request]
+on:
+  pull_request:
+  push:
+    branches:
+      - master
 
 env:
   PYTHON_VERSION: 3.8

.github/workflows/test-macos.yml

@@ -1,6 +1,10 @@
 name: test-macOS
 
-on: [push, pull_request]
+on:
+  pull_request:
+  push:
+    branches:
+      - master
 
 env:
   PYTHON_VERSION: 3.8

CHANGELOG.md

@@ -31,7 +31,8 @@ release.
 </tr>
 <tr>
     <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V14.md#14.6.0">14.6.0</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V14.md#14.7.0">14.7.0</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V14.md#14.6.0">14.6.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V14.md#14.5.0">14.5.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V14.md#14.4.0">14.4.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V14.md#14.3.0">14.3.0</a><br/>
@@ -40,23 +41,6 @@ release.
 <a href="doc/changelogs/CHANGELOG_V14.md#14.0.0">14.0.0</a><br/>
     </td>
     <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V13.md#13.12.0">13.12.0</a></b><br/>
-<a href="doc/changelogs/CHANGELOG_V13.md#13.11.0">13.11.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V13.md#13.10.1">13.10.1</a><br/>
-<a href="doc/changelogs/CHANGELOG_V13.md#13.10.0">13.10.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V13.md#13.9.0">13.9.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V13.md#13.8.0">13.8.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V13.md#13.7.0">13.7.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V13.md#13.6.0">13.6.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V13.md#13.5.0">13.5.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V13.md#13.4.0">13.4.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V13.md#13.3.0">13.3.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V13.md#13.2.0">13.2.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V13.md#13.1.0">13.1.0</a><br/>
-<a href="doc/changelogs/CHANGELOG_V13.md#13.0.1">13.0.1</a><br/>
-<a href="doc/changelogs/CHANGELOG_V13.md#13.0.0">13.0.0</a><br/>
-    </td>
-    <td valign="top">
 <b><a href="doc/changelogs/CHANGELOG_V12.md#12.16.2">12.16.2</a></b><br/>
 <a href="doc/changelogs/CHANGELOG_V12.md#12.16.1">12.16.1</a><br/>
 <a href="doc/changelogs/CHANGELOG_V12.md#12.16.0">12.16.0</a><br/>

GOVERNANCE.md

@@ -2,16 +2,30 @@
 
 <!-- TOC -->
 
+* [Triagers](#triagers)
 * [Collaborators](#collaborators)
-  * [Collaborator Activities](#collaborator-activities)
-* [Technical Steering Committee](#technical-steering-committee)
-  * [TSC Meetings](#tsc-meetings)
-* [Collaborator Nominations](#collaborator-nominations)
+  * [Collaborator activities](#collaborator-activities)
+* [Technical steering committee](#technical-steering-committee)
+  * [TSC meetings](#tsc-meetings)
+* [Collaborator nominations](#collaborator-nominations)
   * [Onboarding](#onboarding)
-* [Consensus Seeking Process](#consensus-seeking-process)
+* [Consensus seeking process](#consensus-seeking-process)
 
 <!-- /TOC -->
 
+## Triagers
+
+Triagers assess newly-opened issues in the nodejs/node and nodejs/help
+repositories. There is no GitHub team for triagers at the moment.
+
+Triagers have:
+* ability to label issues
+* ability to comment, close, and reopen issues
+
+See:
+
+* [A guide for triagers](./doc/guides/contributing/issues.md#triaging-a-bug-report)
+
 ## Collaborators
 
 Node.js Core Collaborators maintain the [nodejs/node][] GitHub repository.
@@ -41,7 +55,7 @@ See:
 * [List of Collaborators](./README.md#current-project-team-members)
 * [A guide for Collaborators](./doc/guides/collaborator-guide.md)
 
-### Collaborator Activities
+### Collaborator activities
 
 * Helping users and novice contributors
 * Contributing code and documentation changes that improve the project
@@ -70,7 +84,7 @@ The current list of TSC members is in
 The [TSC Charter][] governs the operations of the TSC. All changes to the
 Charter need approval by the OpenJS Foundation Board of Directors.
 
-### TSC Meetings
+### TSC meetings
 
 The TSC meets in a voice conference call. Each year, the TSC elects a chair to
 run the meetings. The TSC streams its meetings for public viewing on YouTube or
@@ -104,7 +118,7 @@ the issue tracker is:
   and no TSC opposition.
 * If there is an extended impasse, a TSC member may make a motion for a vote.
 
-## Collaborator Nominations
+## Collaborator nominations
 
 Existing Collaborators can nominate someone to become a Collaborator. Nominees
 should have significant and valuable contributions across the Node.js
@@ -151,7 +165,7 @@ After the nomination passes, a TSC member onboards the new Collaborator. See
 [the onboarding guide](./onboarding.md) for details of the onboarding
 process.
 
-## Consensus Seeking Process
+## Consensus seeking process
 
 The TSC follows a [Consensus Seeking][] decision-making model per the
 [TSC Charter][].

Makefile

@@ -298,8 +298,8 @@ v8:
 jstest: build-addons build-js-native-api-tests build-node-api-tests ## Runs addon tests and JS tests
 	$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) \
 		--skip-tests=$(CI_SKIP_TESTS) \
-		$(CI_JS_SUITES) \
-		$(CI_NATIVE_SUITES)
+		$(JS_SUITES) \
+		$(NATIVE_SUITES)
 
 .PHONY: tooltest
 tooltest:
@@ -492,9 +492,11 @@ test-all-valgrind: test-build
 test-all-suites: | clear-stalled test-build bench-addons-build doc-only ## Run all test suites.
 	$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) test/*
 
+JS_SUITES ?= default
+NATIVE_SUITES ?= addons js-native-api node-api
 # CI_* variables should be kept synchronized with the ones in vcbuild.bat
-CI_NATIVE_SUITES ?= addons js-native-api node-api
-CI_JS_SUITES ?= default
+CI_NATIVE_SUITES ?= $(NATIVE_SUITES) benchmark
+CI_JS_SUITES ?= $(JS_SUITES)
 ifeq ($(node_use_openssl), false)
 	CI_DOC := doctool
 else
@@ -505,7 +507,7 @@ endif
 # Build and test addons without building anything else
 # Related CI job: node-test-commit-arm-fanned
 test-ci-native: LOGLEVEL := info
-test-ci-native: | test/addons/.buildstamp test/js-native-api/.buildstamp test/node-api/.buildstamp
+test-ci-native: | benchmark/napi/.buildstamp test/addons/.buildstamp test/js-native-api/.buildstamp test/node-api/.buildstamp
 	$(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap \
 		--mode=$(BUILDTYPE_LOWER) --flaky-tests=$(FLAKY_TESTS) \
 		$(TEST_CI_ARGS) $(CI_NATIVE_SUITES)
@@ -527,7 +529,7 @@ test-ci-js: | clear-stalled
 .PHONY: test-ci
 # Related CI jobs: most CI tests, excluding node-test-commit-arm-fanned
 test-ci: LOGLEVEL := info
-test-ci: | clear-stalled build-addons build-js-native-api-tests build-node-api-tests doc-only
+test-ci: | clear-stalled bench-addons-build build-addons build-js-native-api-tests build-node-api-tests doc-only
 	out/Release/cctest --gtest_output=xml:out/junit/cctest.xml
 	$(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap \
 		--mode=$(BUILDTYPE_LOWER) --flaky-tests=$(FLAKY_TESTS) \
@@ -654,8 +656,8 @@ test-with-async-hooks:
 	$(MAKE) build-node-api-tests
 	$(MAKE) cctest
 	NODE_TEST_WITH_ASYNC_HOOKS=1 $(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) \
-		$(CI_JS_SUITES) \
-		$(CI_NATIVE_SUITES)
+		$(JS_SUITES) \
+		$(NATIVE_SUITES)
 
 
 .PHONY: test-v8
@@ -1034,7 +1036,7 @@ pkg-upload: pkg
 	scp -p $(TARNAME).pkg $(STAGINGSERVER):nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME).pkg
 	ssh $(STAGINGSERVER) "touch nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME).pkg.done"
 
-$(TARBALL): release-only $(NODE_EXE) doc
+$(TARBALL): release-only doc-only
 	git checkout-index -a -f --prefix=$(TARNAME)/
 	mkdir -p $(TARNAME)/doc/api
 	cp doc/node.1 $(TARNAME)/doc/node.1