Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: suppress ExperimentalWarning #36797

Closed
wants to merge 1 commit into from
Closed

test: suppress ExperimentalWarning #36797

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Jan 5, 2021

This commit suppresses the ExperimentalWarning that is generated by
EnvironmentTest.EnvironmentWithESMLoader:

$ ./out/Release/cctest \
  --gtest_filter=EnvironmentTest.EnvironmentWithESMLoader
Running main() from ../test/cctest/gtest/gtest_main.cc
Note: Google Test filter = EnvironmentTest.EnvironmentWithESMLoader
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from EnvironmentTest
[ RUN      ] EnvironmentTest.EnvironmentWithESMLoader
(node:3829122) ExperimentalWarning:
VM Modules is an experimental feature. This feature could change at any
time
(Use `node --trace-warnings ...` to show where the warning was created)
[       OK ] EnvironmentTest.EnvironmentWithESMLoader (83 ms)
[----------] 1 test from EnvironmentTest (83 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (86 ms total)
[  PASSED  ] 1 test.

@danbev
test: suppress ExperimentalWarning
5b2c934 
This commit suppresses the ExperimentalWarning that is generated by
EnvironmentTest.EnvironmentWithESMLoader:

$ ./out/Release/cctest \
  --gtest_filter=EnvironmentTest.EnvironmentWithESMLoader
Running main() from ../test/cctest/gtest/gtest_main.cc
Note: Google Test filter = EnvironmentTest.EnvironmentWithESMLoader
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from EnvironmentTest
[ RUN      ] EnvironmentTest.EnvironmentWithESMLoader
(node:3829122) ExperimentalWarning:
VM Modules is an experimental feature. This feature could change at any
time
(Use `node --trace-warnings ...` to show where the warning was created)
[       OK ] EnvironmentTest.EnvironmentWithESMLoader (83 ms)
[----------] 1 test from EnvironmentTest (83 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (86 ms total)
[  PASSED  ] 1 test.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 5, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35293/

@PoojaDurgad PoojaDurgad added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 5, 2021
@aduh95 aduh95 added the review wanted PRs that need reviews. label Jan 18, 2021
@PoojaDurgad
Copy link
Contributor

requires rebase to address git conflicts

@danbev danbev closed this Aug 23, 2021
@danbev danbev deleted the suppress-stderr-environmentwithemsloader branch August 23, 2021 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. review wanted PRs that need reviews. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danbev @nodejs-github-bot @PoojaDurgad @aduh95