Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quic: remove duplicate checks #37017

Closed
wants to merge 1 commit into from
Closed

quic: remove duplicate checks #37017

wants to merge 1 commit into from

Conversation

Lxxyx
Copy link
Member

@Lxxyx Lxxyx commented Jan 21, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added dont-land-on-v12.x quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Jan 21, 2021
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 21, 2021
@aduh95
Copy link
Contributor

aduh95 commented Jan 21, 2021

@RaisinTen don't forget to spawn a CI job before marking PR as author ready (unless it's a doc-only change).

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35654/

@RaisinTen
Copy link
Contributor

@aduh95 Thanks for telling. I will do it next time for sure. :)

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35688/

@Trott
Copy link
Member

Trott commented Jan 23, 2021

Landed in 0e7e91f

@Trott Trott closed this Jan 23, 2021
Trott pushed a commit to Trott/io.js that referenced this pull request Jan 23, 2021
@Lxxyx @Trott
quic: remove duplicate checks
0e7e91f 
PR-URL: nodejs#37017
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Lxxyx Lxxyx deleted the quic-remove-duplicate-checks branch January 23, 2021 12:20
targos pushed a commit that referenced this pull request Feb 2, 2021
@Lxxyx @targos
quic: remove duplicate checks
b533485 
PR-URL: #37017
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Feb 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@aduh95 aduh95 aduh95 approved these changes

@juanarbol juanarbol juanarbol approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Lxxyx @aduh95 @nodejs-github-bot @RaisinTen @Trott @jasnell @lpinca @cjihrig @juanarbol