Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add support for Visual Studio 2022 #39857

Closed
wants to merge 3 commits into from
Closed

build: add support for Visual Studio 2022 #39857

wants to merge 3 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Aug 24, 2021

  • tools: add support for Visual Studio 2022 in GYP
  • build: add support for Visual Studio 2022
  • build: add windows-2022 to GitHub test matrix
  • meta: temporarily run in draft

This is a blind try after seeing https://github.blog/changelog/2021-08-23-github-actions-windows-server-2022-with-visual-studio-2022-is-now-available-on-github-hosted-runners-public-beta/
I do not have VS2022 on my computer.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. dont-land-on-v12.x gyp Issues and PRs related to the GYP tool and .gyp build files meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels Aug 24, 2021
@targos
Copy link
Member Author

targos commented Aug 24, 2021

Looks good!

Looking for Visual Studio 2022
calling: "C:\Program Files\Microsoft Visual Studio\2022\Preview\VC\\Auxiliary\Build\vcvarsall.bat" amd64
**********************************************************************
** Visual Studio 2022 Developer Command Prompt v17.0.0-pre.3.1
** Copyright (c) 2021 Microsoft Corporation
**********************************************************************
[vcvarsall.bat] Environment initialized for: 'x64'
Found MSVS version 17.0
configure  --dest-cpu=x64

image

@targos targos mentioned this pull request Aug 24, 2021
Merged
@targos
Copy link
Member Author

targos commented Aug 24, 2021

Upstreamed the GYP changes in nodejs/gyp-next#124

@targos targos marked this pull request as ready for review August 30, 2021 14:55
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 30, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 30, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39715/

targos added a commit that referenced this pull request Sep 1, 2021
@targos
tools: update gyp-next to v0.10.0
4595a0e 
PR-URL: #39857
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this pull request Sep 1, 2021
@targos
build: add support for Visual Studio 2022
c5eadb4 
PR-URL: #39857
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this pull request Sep 1, 2021
@targos
build: add windows-2022 to GitHub test matrix
13b569c 
PR-URL: #39857
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@targos
Copy link
Member Author

targos commented Sep 1, 2021

Landed in 73d5f8a...13b569c

@targos targos closed this Sep 1, 2021
@targos targos deleted the vs-2022 branch September 1, 2021 21:12
@targos targos mentioned this pull request Sep 2, 2021
Closed
targos added a commit that referenced this pull request Sep 6, 2021
@targos
tools: update gyp-next to v0.10.0
554dcf4 
PR-URL: #39857
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this pull request Sep 6, 2021
@targos
build: add support for Visual Studio 2022
ea4ebbf 
PR-URL: #39857
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this pull request Sep 6, 2021
@targos
build: add windows-2022 to GitHub test matrix
235610d 
PR-URL: #39857
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this pull request Sep 6, 2021
@targos
tools: update gyp-next to v0.10.0
9763561 
PR-URL: #39857
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this pull request Sep 6, 2021
@targos
build: add support for Visual Studio 2022
c49b0c0 
PR-URL: #39857
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this pull request Sep 6, 2021
@targos
build: add windows-2022 to GitHub test matrix
e783453 
PR-URL: #39857
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@targos targos mentioned this pull request Sep 6, 2021
Merged
@FlipTheOne
Copy link

@targos : I have windows and vs 2022 build issues on latest v16 and on latest v18 nodejs. Is the issue known and is an fix in the pipeline?

@targos
Copy link
Member Author

targos commented Jul 4, 2022

Yes, it's a known issue: #43092
Unfortunately the bug is in Visual Studio and we are still waiting for a fix from Microsoft.

@FlipTheOne
Copy link

tnx for clarification.

@dennisameling dennisameling mentioned this pull request Aug 23, 2022
Closed
wongsyrone pushed a commit to wongsyrone/nodejs-with-mod that referenced this pull request Feb 13, 2024
@targos @wongsyrone
build: add support for Visual Studio 2022
aa7bdc0 
mod by wongsyrone

PR-URL: nodejs#39857
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
wongsyrone pushed a commit to wongsyrone/nodejs-with-mod that referenced this pull request Feb 14, 2024
@targos @wongsyrone
Backport upstream vcbuild.bat for vs 2022
b5e15dd 
build: add support for Visual Studio 2022

PR-URL: nodejs#39857
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
wongsyrone pushed a commit to wongsyrone/nodejs-with-mod that referenced this pull request Feb 15, 2024
@targos @wongsyrone
Backport upstream vcbuild.bat for vs 2022
cf87ea8 
build: add support for Visual Studio 2022

PR-URL: nodejs#39857
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mesteery Mesteery Mesteery left review comments

@richardlau richardlau richardlau approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. gyp Issues and PRs related to the GYP tool and .gyp build files meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@targos @nodejs-github-bot @FlipTheOne @jasnell @richardlau @Mesteery