Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve grammar in API description #40959

Merged
merged 1 commit into from
Nov 26, 2021
Merged

doc: improve grammar in API description #40959

merged 1 commit into from
Nov 26, 2021

Conversation

tniessen
Copy link
Member

No description provided.

@tniessen tniessen requested a review from Trott November 24, 2021 23:39
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem. labels Nov 24, 2021
Trott
Trott approved these changes Nov 25, 2021
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://twitter.com/trott/status/1463629417515683840

image

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 25, 2021
@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 25, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 26, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 26, 2021
@nodejs-github-bot nodejs-github-bot merged commit 230bce8 into nodejs:master Nov 26, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in 230bce8

targos pushed a commit that referenced this pull request Nov 26, 2021
@tniessen @targos
doc: improve grammar in API description
8966ab3 
PR-URL: #40959
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Nov 26, 2021
Merged
@tniessen tniessen deleted the doc-tls-grammar branch November 26, 2021 18:45
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
@tniessen @danielleadams
doc: improve grammar in API description
13f1ff8 
PR-URL: #40959
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@tniessen @danielleadams
doc: improve grammar in API description
d9fc06b 
PR-URL: #40959
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tniessen @nodejs-github-bot @jasnell @Trott @lpinca @aduh95