doc: fix added: info for outgoingMessage.{,un}cork()
#42711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
doc
aduh95
approved these changes
Apr 12, 2022
marsonya
approved these changes
Apr 13, 2022
marsonya
added
the
author ready
Mesteery
approved these changes
Apr 13, 2022
jasnell
approved these changes
Apr 13, 2022
marsonya
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/42711
✔ Done loading data for nodejs/node/pull/42711
----------------------------------- PR info ------------------------------------
Title doc: fix `added:` info for `outgoingMessage.{,un}cork()` (#42711)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch lpinca:fix/added-info-for-outgoing-message-cork-uncork -> nodejs:master
Labels http, doc, author ready
Commits 1
- doc: fix `added:` info for `outgoingMessage.{,un}cork()`
Committers 1
- Luigi Pinca
PR-URL: https://github.com/nodejs/node/pull/42711
Reviewed-By: Paolo Insogna
Reviewed-By: Antoine du Hamel
Reviewed-By: Akhil Marsonya
Reviewed-By: Mestery
Reviewed-By: James M Snell
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/42711
Reviewed-By: Paolo Insogna
Reviewed-By: Antoine du Hamel
Reviewed-By: Akhil Marsonya
Reviewed-By: Mestery
Reviewed-By: James M Snell
--------------------------------------------------------------------------------
ℹ This PR was created on Tue, 12 Apr 2022 18:52:04 GMT
✔ Approvals: 5
✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/42711#pullrequestreview-940014413
✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/42711#pullrequestreview-940238337
✔ - Akhil Marsonya (@marsonya): https://github.com/nodejs/node/pull/42711#pullrequestreview-940594786
✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/42711#pullrequestreview-940832432
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/42711#pullrequestreview-941135322
✖ This PR needs to wait 11 more hours to land
✔ Last GitHub CI successful
ℹ Green GitHub CI is sufficient
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2165792519 |
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in c4a736c |
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
`outgoingMessage.cork()` and `outgoingMessage.uncork()` were added to Node.js v13.2.0 via 62e15a7 and backported to Node.js v12.16.0 via db8144b. PR-URL: nodejs#42711 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2022
`outgoingMessage.cork()` and `outgoingMessage.uncork()` were added to Node.js v13.2.0 via 62e15a7 and backported to Node.js v12.16.0 via db8144b. PR-URL: #42711 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
`outgoingMessage.cork()` and `outgoingMessage.uncork()` were added to Node.js v13.2.0 via 62e15a7 and backported to Node.js v12.16.0 via db8144b. PR-URL: #42711 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
`outgoingMessage.cork()` and `outgoingMessage.uncork()` were added to Node.js v13.2.0 via 62e15a7 and backported to Node.js v12.16.0 via db8144b. PR-URL: #42711 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 11, 2022
`outgoingMessage.cork()` and `outgoingMessage.uncork()` were added to Node.js v13.2.0 via 62e15a7 and backported to Node.js v12.16.0 via db8144b. PR-URL: #42711 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
`outgoingMessage.cork()` and `outgoingMessage.uncork()` were added to Node.js v13.2.0 via 62e15a7 and backported to Node.js v12.16.0 via db8144b. PR-URL: #42711 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
`outgoingMessage.cork()` and `outgoingMessage.uncork()` were added to Node.js v13.2.0 via 62e15a793a56 and backported to Node.js v12.16.0 via db8144be3187. PR-URL: nodejs/node#42711 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
outgoingMessage.cork()andoutgoingMessage.uncork()were added toNode.js v13.2.0 via 62e15a7 and backported to Node.js v12.16.0 via
db8144b.