-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http: fix failing test #43641
http: fix failing test #43641
Conversation
Fast-track has been requested by @ShogunPanda. Please 👍 to approve. |
This comment was marked as outdated.
This comment was marked as outdated.
@ShogunPanda Could you help me understand why this pr will fix the test failure? |
Unrelated side note: the commit message should start with |
We have lot of flakiness in tests lately. Please do not revert the other PR, I'll work in the next few hours to understand why it fails. |
I found the issue. The problem was not in using the agent but in the fact that the |
766c2e5
to
d62be4d
Compare
test-gc-http-client-timeout fail with |
@ShogunPanda After some investigation, I found this is also caused by #43522. 😹 |
My opinion is that after the changes we detect tests that were misbehaving on handling the socket. |
This pr causes two tests to fail, this will affect all pr. I would prefer to keep CI green. When you fixed the test, you could land #43522 again. I don't see any downside to that. could you help me to understand why we would better not revert? |
Because apparently CI was not detecting those tests to fail (not even locally) while somehow it is now. So I think we are in a better spot at the moment. |
Moreover, can you share how you detect that the PR is involved? So I can investigate how to fix it |
Ok. I will support you. |
|
Oh, you are on ARM. On MacOS I get a different error. But I suspect it is the same. Working on it. |
I just have noticed that the |
Fast-track has been requested by @tniessen. Please 👍 to approve. |
wow. this tool is great. I don't know that before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Commit Queue failed- Loading data for nodejs/node/pull/43641 ✔ Done loading data for nodejs/node/pull/43641 ----------------------------------- PR info ------------------------------------ Title http: fix failing test (#43641) Author Paolo Insogna (@ShogunPanda) Branch ShogunPanda:fix-failing-test -> nodejs:main Labels test, fast-track, needs-ci Commits 2 - http: fix failing test - http: moved test to sequential Committers 1 - Paolo Insogna PR-URL: https://github.com/nodejs/node/pull/43641 Reviewed-By: Matteo Collina Reviewed-By: Filip Skokan ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43641 Reviewed-By: Matteo Collina Reviewed-By: Filip Skokan -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 01 Jul 2022 09:29:46 GMT ✔ Approvals: 2 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/43641#pullrequestreview-1026765760 ✔ - Filip Skokan (@panva): https://github.com/nodejs/node/pull/43641#pullrequestreview-1026768532 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-07-02T04:04:05Z: https://ci.nodejs.org/job/node-test-pull-request/45045/ - Querying data for job/node-test-pull-request/45045/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 43641 From https://github.com/nodejs/node * branch refs/pull/43641/merge -> FETCH_HEAD ✔ Fetched commits as 201460873d07..64cf037bbed1 -------------------------------------------------------------------------------- [main f57c58aa05] http: fix failing test Author: Paolo Insogna Date: Fri Jul 1 13:39:05 2022 +0200 1 file changed, 3 insertions(+), 1 deletion(-) [main 344ac7b8a0] http: moved test to sequential Author: Paolo Insogna Date: Fri Jul 1 16:29:04 2022 +0200 1 file changed, 0 insertions(+), 0 deletions(-) rename test/{parallel => sequential}/test-gc-http-client-timeout.js (100%) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/2602070703 |
Landed in c753f27 |
@tniessen Could we file an issue to nodejs/build or nodejs/node to record this bug? I tried to fix it to the main branch in nodejs/build repo, but I cannot figure out where the Jenkins file of |
@ShogunPanda test-gc-http-client-timeout is still flaky after move to sequential: https://ci.nodejs.org/job/node-test-commit-arm/42478/nodes=ubuntu2004-armv7l/testReport/junit/(root)/test/sequential_test_gc_http_client_timeout/ |
@F3n67u I'll soon file a request to @nodejs/build to get access to machine and investigate it. On macOS it does not happen |
Great. thank you. |
PR-URL: #43641 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Fixes #43623.