inspector: set sampling interval before start

[codebytere]

Fixes an issue seen in CPU profiling tests:

Receive CPU profile message
{"id":3,"error":{"code":-32000,"message":"Cannot change sampling interval when profiling."}}

which is the result of calling Profiler.setSamplingInterval after calling Profiler.start. V8 explicitly disallows this.

[RaisinTen]

This seems to deflake the sequential/test-cpu-prof-dir-absolute test flake reported in electron/electron#34472. Not sure why we don't have one under flaky-test Issues and PRs related to the tests with unstable failures on the CI. . ¯\_(ツ)_/¯

[codebytere]

@RaisinTen unfortunately it doesn't - the root issue there is a DCHECK:

#
# Fatal error in ../../v8/src/execution/frames.h, line 191
# Debug check failed: static_cast<uintptr_t>(type) < Type::NUMBER_OF_TYPES (69908642730676 vs. 25).
#
#
#
#FailureMessage Object: 0x7f29bfa20370
 1: 0x55cffc09a3e2  [/home/parallels/Developer/electron-gn/src/out/Testing/electron]
 2: 0x55cff8cc3268  [/home/parallels/Developer/electron-gn/src/out/Testing/electron]
 3: 0x55cff8cc2e65  [/home/parallels/Developer/electron-gn/src/out/Testing/electron]
 4: 0x55cff480145e  [/home/parallels/Developer/electron-gn/src/out/Testing/electron]
 5: 0x55cff47ffb0a  [/home/parallels/Developer/electron-gn/src/out/Testing/electron]
 6: 0x55cff4801f1b  [/home/parallels/Developer/electron-gn/src/out/Testing/electron]
 7: 0x55cff4801c62  [/home/parallels/Developer/electron-gn/src/out/Testing/electron]
 8: 0x55cff4801b28  [/home/parallels/Developer/electron-gn/src/out/Testing/electron]
 9: 0x55cff4e0ea6f v8::internal::TickSample::GetStackSample(v8::internal::Isolate*, v8::RegisterState*, v8::internal::TickSample::RecordCEntryFrame, void**, unsigned long, v8::SampleInfo*, v8::StateTag*, bool) [/home/parallels/Developer/electron-gn/src/out/Testing/electron]
10: 0x55cff4e0e464 v8::internal::TickSample::Init(v8::internal::Isolate*, v8::RegisterState const&, v8::internal::TickSample::RecordCEntryFrame, bool, bool, v8::base::TimeDelta) [/home/parallels/Developer/electron-gn/src/out/Testing/electron]
11: 0x55cff4de54ca  [/home/parallels/Developer/electron-gn/src/out/Testing/electron]
12: 0x55cff4a8d1e3 v8::sampler::SamplerManager::DoSample(v8::RegisterState const&) [/home/parallels/Developer/electron-gn/src/out/Testing/electron]
13: 0x55cff4a8d2a1  [/home/parallels/Developer/electron-gn/src/out/Testing/electron]
14: 0x7f29c60813c0  [/lib/x86_64-linux-gnu/libpthread.so.0]
15: 0x55cff477b240 v8::internal::PerThreadAssertScope<(v8::internal::PerThreadAssertType)1, false>::PerThreadAssertScope() [/home/parallels/Developer/electron-gn/src/out/Testing/electron]
16: 0x55cff45a4809  [/home/parallels/Developer/electron-gn/src/out/Testing/electron]
17: 0x55cff487b195  [/home/parallels/Developer/electron-gn/src/out/Testing/electron]
18: 0x55cff487b005  [/home/parallels/Developer/electron-gn/src/out/Testing/electron]
19: 0x55cff487ae35  [/home/parallels/Developer/electron-gn/src/out/Testing/electron]
20: 0x55cff4d3553f  [/home/parallels/Developer/electron-gn/src/out/Testing/electron]
21: 0x55cff4d316bd v8::internal::ScopeInfo::HasSharedFunctionName() const [/home/parallels/Developer/electron-gn/src/out/Testing/electron]
22: 0x55cff4527da4  [/home/parallels/Developer/electron-gn/src/out/Testing/electron]
23: 0x55cff4d3a72d  [/home/parallels/Developer/electron-gn/src/out/Testing/electron]
24: 0x55cff4e07cf9 v8::internal::ProfilerListener::GetFunctionName(v8::internal::SharedFunctionInfo) [/home/parallels/Developer/electron-gn/src/out/Testing/electron]
25: 0x55cff4e077b4 v8::internal::ProfilerListener::CodeCreateEvent(v8::internal::LogEventListener::CodeTag, v8::internal::Handle<v8::internal::AbstractCode>, v8::internal::Handle<v8::internal::SharedFunctionInfo>, v8::internal::Handle<v8::internal::Name>, int, int) [/home/parallels/Developer/electron-gn/src/out/Testing/electron]
26: 0x55cff470fbb4 v8::internal::Compiler::LogFunctionCompilation(v8::internal::Isolate*, v8::internal::LogEventListener::CodeTag, v8::internal::Handle<v8::internal::Script>, v8::internal::Handle<v8::internal::SharedFunctionInfo>, v8::internal::Handle<v8::internal::FeedbackVector>, v8::internal::Handle<v8::internal::AbstractCode>, v8::internal::CodeKind, double) [/home/parallels/Developer/electron-gn/src/out/Testing/electron]
27: 0x55cff45aa8e9  [/home/parallels/Developer/electron-gn/src/out/Testing/electron]
28: 0x55cff45a94eb  [/home/parallels/Developer/electron-gn/src/out/Testing/electron]
29: 0x55cff484854d v8::internal::StackGuard::HandleInterrupts() [/home/parallels/Developer/electron-gn/src/out/Testing/electron]
30: 0x55cff4e60a3c  [/home/parallels/Developer/electron-gn/src/out/Testing/electron]
31: 0x55cff532ea76 v8::internal::RegExpMacroAssemblerX64::CheckStackGuardState(unsigned long*, unsigned long, unsigned long) [/home/parallels/Developer/electron-gn/src/out/Testing/electron]
32: 0x55cf601af90f

still occurs after this fix.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/45659/

[nodejs-github-bot]

Landed in 92e6342