v16.17.0 release proposal

.eslintignore

@@ -7,4 +7,5 @@ tools/icu
 tools/lint-md/lint-md.mjs
 benchmark/tmp
 doc/**/*.js
+!doc/api_assets/*.js
 !.eslintrc.js

.eslintrc.js

@@ -260,6 +260,7 @@ module.exports = {
     'no-useless-concat': 'error',
     'no-useless-constructor': 'error',
     'no-useless-return': 'error',
+    'no-var': 'error',
     'no-void': 'error',
     'no-whitespace-before-property': 'error',
     'object-curly-newline': 'error',
@@ -319,6 +320,7 @@ module.exports = {
     'node-core/no-duplicate-requires': 'error',
   },
   globals: {
+    CustomEvent: 'readable',
     Crypto: 'readable',
     CryptoKey: 'readable',
     fetch: 'readable',

.gitattributes

@@ -1,3 +1,6 @@
 test/fixtures/* -text
 vcbuild.bat text eol=crlf
+deps/npm/bin/npm text eol=lf
+deps/npm/bin/npx text eol=lf
+deps/corepack/shims/corepack text eol=lf
 tools/msvs/find_python.cmd text eol=crlf

.github/ISSUE_TEMPLATE/4-report-a-flaky-test.yml

@@ -19,11 +19,24 @@ body:
       placeholder: e.g. `test-fs-stat-bigint`
     validations:
       required: true
-  - type: input
+  - type: dropdown
     attributes:
       label: Platform
       description: The platform the test is flaky on.
-      placeholder: e.g. `macos` or `linux`
+      multiple: true
+      options:
+        - AIX
+        - FreeBSD
+        - Linux ARM64
+        - Linux ARMv7
+        - Linux PPC64LE
+        - Linux s390x
+        - Linux x64
+        - macOS ARM64
+        - macOS x64
+        - SmartOS
+        - Windows
+        - Other
   - type: textarea
     attributes:
       label: Console output

.github/ISSUE_TEMPLATE/config.yml

@@ -1,4 +1,4 @@
-blank_issues_enabled: false
+blank_issues_enabled: true
 contact_links:
   - name: ⁉️ Need help with Node.js?
     url: https://github.com/nodejs/help

.github/label-pr-config.yml

@@ -26,7 +26,7 @@ subSystemLabels:
   /^src\/.*win32.*/: c++, windows
   /^src\/node_zlib/: c++, zlib
   /^src\/tracing/: c++, tracing
-  /^src\/node_api/: c++, node-api
+  /^src\/(?:node_api|js_native_api)/: c++, node-api
   /^src\/node_http2/: c++, http2
   /^src\/node_report/: c++, report
   /^src\/node_wasi/: c++, wasi
@@ -67,7 +67,7 @@ subSystemLabels:
   /^tools\/make-v8/: tools, v8 engine, needs-ci
   /^tools\/v8_gypfiles/: tools, v8 engine, needs-ci
   /^tools\/(code_cache|snapshot)/: needs-ci
-  /^tools\/build-addons.js/: needs-ci
+  /^tools\/build-addons.mjs/: needs-ci
   # all other tool changes should be marked as such
   /^tools\//: tools
   /^\.eslint|\.remark|\.editorconfig/: tools
@@ -117,7 +117,8 @@ exlusiveLabels:
   /^test\/inspector\//: test, inspector
   /^test\/cctest\/test_inspector/: test, inspector
   /^test\/cctest\/test_url/: test, whatwg-url
-  /^test\/addons-napi\//: test, node-api
+  /^test\/node-api\//: test, node-api
+  /^test\/js-native-api\//: test, node-api
   /^test\/async-hooks\//: test, async_hooks
   /^test\/report\//: test, report
   /^test\/fixtures\/es-module/: test, esm

.github/workflows/authors.yml

@@ -6,25 +6,30 @@ on:
 
   workflow_dispatch:
 
+permissions:
+  contents: read
+
 jobs:
   authors_update:
     if: github.repository == 'nodejs/node'
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         with:
           fetch-depth: '0'  # This is required to actually get all the authors
           persist-credentials: false
-      - run: tools/update-authors.js  # Run the AUTHORS tool
-      - uses: gr2m/create-or-update-pull-request-action@v1  # Create a PR or update the Action's existing PR
+      - run: tools/update-authors.mjs  # Run the AUTHORS tool
+      - uses: gr2m/create-or-update-pull-request-action@6720400cad8e74d7adc64640e4e6ea6748b83d8f
+        # Creates a PR or update the Action's existing PR, or
+        # no-op if the base branch is already up-to-date.
         env:
           GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
         with:
           author: Node.js GitHub Bot <github-bot@iojs.org>
           body: >
             Here are some new additions to the AUTHORS file.
             This is an automatically generated PR by the
-            `authors.yml` GitHub Action, which runs `tools/update-authors.js`.
+            `authors.yml` GitHub Action, which runs `tools/update-authors.mjs`.
           branch: actions/authors-update  # Custom branch *just* for this Action.
           commit-message: 'meta: update AUTHORS'
           labels: meta

.github/workflows/auto-start-ci.yml

@@ -13,8 +13,13 @@ concurrency: ${{ github.workflow }}
 env:
   NODE_VERSION: lts/*
 
+permissions:
+  contents: read
+
 jobs:
   get-prs-for-ci:
+    permissions:
+      pull-requests: read
     if: github.repository == 'nodejs/node'
     runs-on: ubuntu-latest
     outputs:
@@ -32,16 +37,19 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
   start-ci:
+    permissions:
+      contents: read
+      pull-requests: write
     needs: get-prs-for-ci
     if: needs.get-prs-for-ci.outputs.numbers != ''
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         with:
           persist-credentials: false
 
       - name: Install Node.js
-        uses: actions/setup-node@v2
+        uses: actions/setup-node@v3
         with:
           node-version: ${{ env.NODE_VERSION }}
 

.github/workflows/build-tarball.yml

@@ -12,7 +12,6 @@ on:
       - '!.github/workflows/build-tarball.yml'
   push:
     branches:
-      - master
       - main
       - v[0-9]+.x-staging
       - v[0-9]+.x
@@ -30,18 +29,21 @@ concurrency:
 
 env:
   PYTHON_VERSION: '3.10'
-  FLAKY_TESTS: dontcare
+  FLAKY_TESTS: keep_retrying
+
+permissions:
+  contents: read
 
 jobs:
   build-tarball:
     if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         with:
           persist-credentials: false
       - name: Set up Python ${{ env.PYTHON_VERSION }}
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v3
         with:
           python-version: ${{ env.PYTHON_VERSION }}
       - name: Environment Information
@@ -55,25 +57,25 @@ jobs:
           mkdir tarballs
           mv *.tar.gz tarballs
       - name: Upload tarball artifact
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v3
         with:
           name: tarballs
           path: tarballs
   test-tarball-linux:
     needs: build-tarball
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         with:
           persist-credentials: false
       - name: Set up Python ${{ env.PYTHON_VERSION }}
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v3
         with:
           python-version: ${{ env.PYTHON_VERSION }}
       - name: Environment Information
         run: npx envinfo
       - name: Download tarball
-        uses: actions/download-artifact@v2
+        uses: actions/download-artifact@v3
         with:
           name: tarballs
           path: tarballs
@@ -92,4 +94,4 @@ jobs:
       - name: Test
         run: |
           cd $TAR_DIR
-          make run-ci -j2 V=1 TEST_CI_ARGS="-p dots"
+          make run-ci -j2 V=1 TEST_CI_ARGS="-p dots --measure-flakiness 9"

.github/workflows/build-windows.yml

@@ -9,7 +9,6 @@ on:
     types: [opened, synchronize, reopened, ready_for_review]
   push:
     branches:
-      - master
       - main
       - canary
       - v[0-9]+.x-staging
@@ -25,18 +24,21 @@ concurrency:
 
 env:
   PYTHON_VERSION: '3.10'
-  FLAKY_TESTS: dontcare
+  FLAKY_TESTS: keep_retrying
+
+permissions:
+  contents: read
 
 jobs:
   build-windows:
     if: github.event.pull_request.draft == false
     runs-on: windows-2019
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         with:
           persist-credentials: false
       - name: Set up Python ${{ env.PYTHON_VERSION }}
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v3
         with:
           python-version: ${{ env.PYTHON_VERSION }}
       - name: Install deps

.github/workflows/close-stale-feature-requests.yml

@@ -1,12 +1,9 @@
 name: Close stale feature requests
 on:
   workflow_dispatch:
-    inputs:
-      daysBeforeStale:
-        description: Idle number of days before marking feature requests stale
-        required: true
-        default: 906
-        type: number
+  schedule:
+    # Run every day at 1:00 AM UTC.
+    - cron: 0 1 * * *
 
 # yamllint disable rule:empty-lines
 env:
@@ -31,15 +28,21 @@ env:
     [feature request management document](https://github.com/nodejs/node/blob/HEAD/doc/contributing/feature-request-management.md).
 # yamllint enable
 
+permissions:
+  contents: read
+
 jobs:
   stale:
+    permissions:
+      issues: write  # for actions/stale to close stale issues
+      pull-requests: write  # for actions/stale to close stale PRs
     if: github.repository == 'nodejs/node'
     runs-on: ubuntu-latest
     steps:
       - uses: actions/stale@v4
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
-          days-before-stale: ${{ github.event.inputs.daysBeforeStale }}
+          days-before-stale: 180
           days-before-close: 30
           stale-issue-label: stale
           close-issue-message: ${{ env.CLOSE_MESSAGE }}

.github/workflows/close-stalled.yml

@@ -9,8 +9,14 @@ env:
     is still relevant, or to ping the collaborator who labelled it stalled if
     you have any questions.
 
+permissions:
+  contents: read
+
 jobs:
   stale:
+    permissions:
+      issues: write  # for actions/stale to close stale issues
+      pull-requests: write  # for actions/stale to close stale PRs
     if: github.repository == 'nodejs/node'
     runs-on: ubuntu-latest
     steps:

.github/workflows/comment-labeled.yml

@@ -11,8 +11,14 @@ env:
     If it should remain open, please leave a comment explaining why it should remain open.
   FAST_TRACK_MESSAGE: Fast-track has been requested by @${{ github.actor }}. Please 👍 to approve.
 
+permissions:
+  contents: read
+
 jobs:
   stale-comment:
+    permissions:
+      issues: write
+      pull-requests: write
     if: github.repository == 'nodejs/node' && github.event.label.name == 'stalled'
     runs-on: ubuntu-latest
     steps:
@@ -23,6 +29,8 @@ jobs:
         run: gh issue comment "$NUMBER" --repo ${{ github.repository }} --body "$STALE_MESSAGE"
 
   fast-track:
+    permissions:
+      pull-requests: write
     if: github.repository == 'nodejs/node' && github.event_name == 'pull_request_target' && github.event.label.name == 'fast-track'
     runs-on: ubuntu-latest
     steps:

.github/workflows/commit-lint.yml

@@ -5,6 +5,9 @@ on: [pull_request]
 env:
   NODE_VERSION: lts/*
 
+permissions:
+  contents: read
+
 jobs:
   lint-commit-message:
     runs-on: ubuntu-latest
@@ -14,13 +17,13 @@ jobs:
         run: |
           echo "::set-output name=plusOne::$((${{ github.event.pull_request.commits }} + 1))"
           echo "::set-output name=minusOne::$((${{ github.event.pull_request.commits }} - 1))"
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         with:
           fetch-depth: ${{ steps.nb-of-commits.outputs.plusOne }}
           persist-credentials: false
       - run: git reset HEAD^2
       - name: Install Node.js
-        uses: actions/setup-node@v2
+        uses: actions/setup-node@v3
         with:
           node-version: ${{ env.NODE_VERSION }}
       - name: Validate commit message

.github/workflows/commit-queue.yml

@@ -18,8 +18,13 @@ concurrency: ${{ github.workflow }}
 env:
   NODE_VERSION: lts/*
 
+permissions:
+  contents: read
+
 jobs:
   get_mergeable_prs:
+    permissions:
+      pull-requests: read
     if: github.repository == 'nodejs/node'
     runs-on: ubuntu-latest
     outputs:
@@ -42,7 +47,7 @@ jobs:
     if: needs.get_mergeable_prs.outputs.numbers != ''
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         with:
           # Needs the whole git history for ncu to work
           # See https://github.com/nodejs/node-core-utils/pull/486
@@ -55,7 +60,7 @@ jobs:
 
       # Install dependencies
       - name: Install Node.js
-        uses: actions/setup-node@v2
+        uses: actions/setup-node@v3
         with:
           node-version: ${{ env.NODE_VERSION }}
       - name: Install node-core-utils