-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: add --max-semi-space-size to the options allowed in NODE_OPTIONS #44436
src: add --max-semi-space-size to the options allowed in NODE_OPTIONS #44436
Conversation
Can you add a test to test/parallel/test-cli-node-options.js? Look for |
Test added. I guess this test doesn't actually test whether passing |
Hmm, not sure what to make of the ASan failure; I can't get much from the log. Is it a known intermittent failure? |
4a87691
to
b546a13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Is there anything I need to (or can) do to help this get merged? I don't know what the usual timeline is for changes to get merged. |
I rebased for the change from |
Commit Queue failed- Loading data for nodejs/node/pull/44436 ✔ Done loading data for nodejs/node/pull/44436 ----------------------------------- PR info ------------------------------------ Title src: add --max-semi-space-size to the options allowed in NODE_OPTIONS (#44436) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch ehoogeveen-medweb:allow-v8-option-in-node-options -> nodejs:main Labels c++, needs-ci Commits 2 - src: add --max-semi-space-size to the options allowed in NODE_OPTIONS - test: add a test for --max-semi-space-size Committers 1 - Emanuel Hoogeveen PR-URL: https://github.com/nodejs/node/pull/44436 Reviewed-By: Luigi Pinca Reviewed-By: Ben Noordhuis Reviewed-By: Evan Lucas Reviewed-By: Michael Dawson Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44436 Reviewed-By: Luigi Pinca Reviewed-By: Ben Noordhuis Reviewed-By: Evan Lucas Reviewed-By: Michael Dawson Reviewed-By: James M Snell -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - src: add --max-semi-space-size to the options allowed in NODE_OPTIONS ⚠ - test: add a test for --max-semi-space-size ℹ This PR was created on Mon, 29 Aug 2022 13:54:41 GMT ✔ Approvals: 5 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/44436#pullrequestreview-1092400509 ✔ - Ben Noordhuis (@bnoordhuis): https://github.com/nodejs/node/pull/44436#pullrequestreview-1092635321 ✔ - Evan Lucas (@evanlucas): https://github.com/nodejs/node/pull/44436#pullrequestreview-1109389839 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/44436#pullrequestreview-1119041801 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/44436#pullrequestreview-1127616249 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-11-01T13:37:56Z: https://ci.nodejs.org/job/node-test-pull-request/47616/ - Querying data for job/node-test-pull-request/47616/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3370181684 |
Hmm, I didn't realize that my email address was set to private. I've made it public. |
@lpinca Hi, can you help with this PR ? I am not sure which label we should add. |
Landed in 0d8a782 |
Thanks for the reviews and approvals, and the assistance with getting this merged! 🎉 |
PR-URL: #44436 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #44436 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #44436 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #44436 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #44436 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
--max-semi-space-size was added to the Useful V8 options in #42575, but if you pass it in the NODE_OPTIONS environment variable, you still get
node: --max-semi-space-size= is not allowed in NODE_OPTIONS
.Since the option is explicitly documented as being useful and since
NODE_OPTIONS
appears to be the supported way of passing parameters to the node process from npm, I think it should be included in the options passed through byNODE_OPTIONS
.It appears that this issue was not contemplated in the original request, although there is a comment asking for it: #42511 (comment)