Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unused variable in addon test #44809

Merged
merged 1 commit into from Oct 2, 2022

Conversation

joyeecheung
Copy link
Member

This fixes the compiler warning for the unused variable in the report-api addon test.

This fixes the compiler warning for the unused variable in the
report-api addon test.
@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 28, 2022
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2022
lpinca
lpinca approved these changes Sep 28, 2022
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2022
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot
Copy link
Contributor

@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 29, 2022
@nodejs-github-bot
Copy link
Contributor

Trott
Trott approved these changes Sep 29, 2022
jasnell
jasnell approved these changes Oct 2, 2022
@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 2, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 2, 2022
@nodejs-github-bot nodejs-github-bot merged commit a16f81e into nodejs:main Oct 2, 2022
61 checks passed
@nodejs-github-bot
Copy link
Contributor

Landed in a16f81e

danielleadams pushed a commit that referenced this pull request Oct 11, 2022
This fixes the compiler warning for the unused variable in the
report-api addon test.

PR-URL: #44809
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addons Issues and PRs related to native addons. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants