benchmark: add initial blob benchmark #44990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
benchmark
|
Can you add a test similar to |
|
Thanks for the review @aduh95. I added the test file. |
BridgeAR
reviewed
Oct 13, 2022
lpinca
approved these changes
Oct 13, 2022
jasnell
approved these changes
Oct 16, 2022
anonrig
added
request-ci
github-actions
bot
removed
the
request-ci
BridgeAR
approved these changes
Oct 17, 2022
anonrig
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/44990 ✔ Done loading data for nodejs/node/pull/44990 ----------------------------------- PR info ------------------------------------ Title benchmark: add initial blob benchmark (#44990) Author Yagiz Nizipli (@anonrig) Branch anonrig:perf/blob-benchmark -> nodejs:main Labels benchmark, author ready Commits 3 - benchmark: add blob benchmark - test: add blob benchmark - benchmark: update blob byte values Committers 1 - Yagiz Nizipli PR-URL: https://github.com/nodejs/node/pull/44990 Reviewed-By: Luigi Pinca Reviewed-By: James M Snell Reviewed-By: Ruben Bridgewater ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44990 Reviewed-By: Luigi Pinca Reviewed-By: James M Snell Reviewed-By: Ruben Bridgewater -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 13 Oct 2022 13:49:07 GMT ✔ Approvals: 3 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/44990#pullrequestreview-1141406993 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/44990#pullrequestreview-1143345652 ✔ - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/44990#pullrequestreview-1143745210 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-10-17T07:29:37Z: https://ci.nodejs.org/job/node-test-pull-request/47290/ - Querying data for job/node-test-pull-request/47290/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 44990 From https://github.com/nodejs/node * branch refs/pull/44990/merge -> FETCH_HEAD ✔ Fetched commits as b65db88fd2cb..a32f9796c8c0 -------------------------------------------------------------------------------- [main 5fab374e51] benchmark: add blob benchmark Author: Yagiz Nizipli Date: Thu Oct 13 16:48:36 2022 +0300 1 file changed, 30 insertions(+) create mode 100644 benchmark/blob/blob.js [main b0b7240cd5] test: add blob benchmark Author: Yagiz Nizipli Date: Thu Oct 13 17:48:19 2022 +0300 1 file changed, 7 insertions(+) create mode 100644 test/benchmark/test-benchmark-blob.js [main c9e7768dcf] benchmark: update blob byte values Author: Yagiz Nizipli Date: Thu Oct 13 18:16:41 2022 +0300 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. Rebasing (2/6)https://github.com/nodejs/node/actions/runs/3264440711 |
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 6adaf23 |
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2022
PR-URL: #44990 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
PR-URL: #44990 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #44990 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #44990 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #44990 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the performance pull request, I opened, this pull request only includes the benchmark.