Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: update AUTHORS #45020

Merged
merged 2 commits into from
Oct 16, 2022
Merged

meta: update AUTHORS #45020

merged 2 commits into from
Oct 16, 2022

Conversation

nodejs-github-bot
Copy link
Collaborator

Here are some new additions to the AUTHORS file. This is an automatically generated PR by the authors.yml GitHub Action, which runs tools/update-authors.mjs.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 16, 2022
Trott
Trott reviewed Oct 16, 2022
View reviewed changes
AUTHORS Outdated Show resolved Hide resolved
Trott
Trott reviewed Oct 16, 2022
View reviewed changes
AUTHORS Outdated Show resolved Hide resolved
@Trott Trott added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Oct 16, 2022
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 16, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 16, 2022
@aduh95
Copy link
Contributor

aduh95 commented Oct 16, 2022

I think at some point we should modify the workflow that opens the PR to make it list possible duplicates to help with reviewing (assuming it is indeed automatisable, I'm not sure).

@Trott
Copy link
Member

Trott commented Oct 16, 2022

I think at some point we should modify the workflow that opens the PR to make it list possible duplicates to help with reviewing (assuming it is indeed automatisable, I'm not sure).

Yeah, the output of tools/update-authors.mjs lists suspected duplicates already. See https://github.com/nodejs/node/actions/runs/3257704667/jobs/5349162871#step:3:5 for an example.

So it would just be a matter of detecting them and including them in the PR description or something like that.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 16, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 16, 2022
@nodejs-github-bot nodejs-github-bot merged commit c0b5c36 into main Oct 16, 2022
@nodejs-github-bot
Copy link
Collaborator Author

Landed in c0b5c36

@nodejs-github-bot nodejs-github-bot deleted the actions/authors-update branch October 16, 2022 14:49
@aduh95
Copy link
Contributor

aduh95 commented Oct 16, 2022

I think at some point we should modify the workflow that opens the PR to make it list possible duplicates to help with reviewing (assuming it is indeed automatisable, I'm not sure).

Yeah, the output of tools/update-authors.mjs lists suspected duplicates already. See https://github.com/nodejs/node/actions/runs/3257704667/jobs/5349162871#step:3:5 for an example.

So it would just be a matter of detecting them and including them in the PR description or something like that.

Or even simply liking to the workflow would already greatly simplify the review process, although your proposal seems of course even better if doable.

RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@nodejs-github-bot @RafaelGSS
meta: update AUTHORS
c542af5 
PR-URL: #45020
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@nodejs-github-bot @RafaelGSS
meta: update AUTHORS
7900810 
PR-URL: #45020
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@nodejs-github-bot @danielleadams
meta: update AUTHORS
8b29b29 
PR-URL: #45020
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@nodejs-github-bot @danielleadams
meta: update AUTHORS
4daf4ae 
PR-URL: #45020
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@nodejs-github-bot @danielleadams
meta: update AUTHORS
9ec6117 
PR-URL: #45020
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@aduh95 aduh95 aduh95 approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nodejs-github-bot @aduh95 @Trott @lpinca @RaisinTen