-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http: Add priority to common http headers #45045
Conversation
Review requested:
|
424c4fe
to
c801c45
Compare
This comment was marked as outdated.
This comment was marked as outdated.
c801c45
to
8b6d4ee
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
the github action asan test is failing for entirely unrelated reasons due to a flaky watch test |
The standard `Priority` header is defined in RFC 9218. This is added as part of the precusor to quic/http3 work. Signed-off-by: James M Snell <jasnell@gmail.com>
8b6d4ee
to
7f311d9
Compare
Fast-track has been requested by @jasnell. Please 👍 to approve. |
Commit Queue failed- Loading data for nodejs/node/pull/45045 ✔ Done loading data for nodejs/node/pull/45045 ----------------------------------- PR info ------------------------------------ Title http: Add priority to common http headers (#45045) Author James M Snell (@jasnell) Branch jasnell:add-http-priority-header -> nodejs:main Labels c++, fast-track, author ready Commits 1 - http: add priority to common http headers Committers 1 - James M Snell PR-URL: https://github.com/nodejs/node/pull/45045 Reviewed-By: Antoine du Hamel Reviewed-By: Yagiz Nizipli Reviewed-By: Matteo Collina Reviewed-By: Robert Nagy Reviewed-By: Rafael Gonzaga Reviewed-By: Darshan Sen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45045 Reviewed-By: Antoine du Hamel Reviewed-By: Yagiz Nizipli Reviewed-By: Matteo Collina Reviewed-By: Robert Nagy Reviewed-By: Rafael Gonzaga Reviewed-By: Darshan Sen -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - http: add priority to common http headers ℹ This PR was created on Mon, 17 Oct 2022 22:05:13 GMT ✔ Approvals: 6 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/45045#pullrequestreview-1144864402 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/45045#pullrequestreview-1145011496 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/45045#pullrequestreview-1145108209 ✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/45045#pullrequestreview-1145112248 ✔ - Rafael Gonzaga (@RafaelGSS): https://github.com/nodejs/node/pull/45045#pullrequestreview-1145659186 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/45045#pullrequestreview-1145900509 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-10-18T14:39:41Z: https://ci.nodejs.org/job/node-test-pull-request/47323/ ⚠ Commits were pushed after the last Full PR CI run: ⚠ - http: add priority to common http headers - Querying data for job/node-test-pull-request/47323/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3282243031 |
Landed in 112bf50 |
The standard `Priority` header is defined in RFC 9218. This is added as part of the precusor to quic/http3 work. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #45045 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
The standard `Priority` header is defined in RFC 9218. This is added as part of the precusor to quic/http3 work. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #45045 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
The standard `Priority` header is defined in RFC 9218. This is added as part of the precusor to quic/http3 work. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #45045 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
The standard `Priority` header is defined in RFC 9218. This is added as part of the precusor to quic/http3 work. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #45045 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
The standard `Priority` header is defined in RFC 9218. This is added as part of the precusor to quic/http3 work. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #45045 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
The standard `Priority` header is defined in RFC 9218. This is added as part of the precusor to quic/http3 work. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #45045 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
The standard
Priority
header is defined in RFC 9218.This is added as part of the precusor to quic/http3 work.
Signed-off-by: James M Snell jasnell@gmail.com
Extracted from the quic PR here: #44325
/cc @nodejs/http @nodejs/http2