-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install: remove unused language files #45138
Conversation
fcd7e16
to
36de209
Compare
"installer" has definitely been used in the past, silly bot. |
If you want to add The |
i18n in the Windows installer was disabled in 2016 for Reasons and never re-enabled. There have been no complaints about lack of localization in the intervening years, suggesting there isn't a huge demand for it either. Let's remove the files because it was confusing at least one potential contributor. Refs: nodejs#45090
36de209
to
0fa45f9
Compare
I took the path of least resistance and switched to |
i18n in the Windows installer was disabled in 2016 for Reasons and never re-enabled. There have been no complaints about lack of localization in the intervening years, suggesting there isn't a huge demand for it either. Let's remove the files because it was confusing at least one potential contributor. Refs: #45090 PR-URL: #45138 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Landed in 9c13e05 |
i18n in the Windows installer was disabled in 2016 for Reasons and never re-enabled. There have been no complaints about lack of localization in the intervening years, suggesting there isn't a huge demand for it either. Let's remove the files because it was confusing at least one potential contributor. Refs: #45090 PR-URL: #45138 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
i18n in the Windows installer was disabled in 2016 for Reasons and never re-enabled. There have been no complaints about lack of localization in the intervening years, suggesting there isn't a huge demand for it either. Let's remove the files because it was confusing at least one potential contributor. Refs: #45090 PR-URL: #45138 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
i18n in the Windows installer was disabled in 2016 for Reasons and never re-enabled. There have been no complaints about lack of localization in the intervening years, suggesting there isn't a huge demand for it either. Let's remove the files because it was confusing at least one potential contributor. Refs: #45090 PR-URL: #45138 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
i18n in the Windows installer was disabled in 2016 for Reasons and never re-enabled. There have been no complaints about lack of localization in the intervening years, suggesting there isn't a huge demand for it either. Let's remove the files because it was confusing at least one potential contributor. Refs: #45090 PR-URL: #45138 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
i18n in the Windows installer was disabled in 2016 for Reasons and never re-enabled. There have been no complaints about lack of localization in the intervening years, suggesting there isn't a huge demand for it either. Let's remove the files because it was confusing at least one potential contributor. Refs: #45090 PR-URL: #45138 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
i18n in the Windows installer was disabled in 2016 for Reasons and never re-enabled.
There have been no complaints about lack of localization in the intervening years, suggesting there isn't a huge demand for it either.
Let's remove the files because it was confusing at least one potential contributor.
Refs: #45090