-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: update lint-md-dependencies to @rollup/plugin-commonjs@23.0.2 @rollup/plugin-node-resolve@15.0.1 rollup@3.2.3 #45237
tools: update lint-md-dependencies to @rollup/plugin-commonjs@23.0.2 @rollup/plugin-node-resolve@15.0.1 rollup@3.2.3 #45237
Conversation
Fast-track has been requested by @aduh95. Please 👍 to approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure what needs to be done in cases like this where the commit message is too long
I usually check out the branch, edit the commit message, and force-push it back to the feature branch. I'll do that now. |
Update @rollup/plugin-commonjs@23.0.2, @rollup/plugin-node-resolve@15.0.1, and rollup@3.2.3.
d5e5fa3
to
72e4905
Compare
Another solution would be to leave it as is and to land it manually, editing the commit message at that time. It's the same result, the only difference being that you save one CI cycle. Speaking of CI, I don't think we need to have a passing Jenkins CI for that kind of change (it's only changing the name of a class), all the CI failures look unrelated anyway. |
I guess I'm still scarred from that one time that a change in lint-md caused CI failures in...like...was it build-without-intl or something? I forget. Some non-default CI build that we test. |
Landed in 548f505 |
Update @rollup/plugin-commonjs@23.0.2, @rollup/plugin-node-resolve@15.0.1, and rollup@3.2.3. PR-URL: #45237 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Update @rollup/plugin-commonjs@23.0.2, @rollup/plugin-node-resolve@15.0.1, and rollup@3.2.3. PR-URL: nodejs#45237 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Update @rollup/plugin-commonjs@23.0.2, @rollup/plugin-node-resolve@15.0.1, and rollup@3.2.3. PR-URL: #45237 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Update @rollup/plugin-commonjs@23.0.2, @rollup/plugin-node-resolve@15.0.1, and rollup@3.2.3. PR-URL: #45237 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Update @rollup/plugin-commonjs@23.0.2, @rollup/plugin-node-resolve@15.0.1, and rollup@3.2.3. PR-URL: #45237 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Update @rollup/plugin-commonjs@23.0.2, @rollup/plugin-node-resolve@15.0.1, and rollup@3.2.3. PR-URL: #45237 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This is an automated update of lint-md-dependencies to @rollup/plugin-commonjs@23.0.2 @rollup/plugin-node-resolve@15.0.1 rollup@3.2.3.