-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update name of Node.js core Slack channel #45293
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name has been changed from nodejs-dev to nodejs-core.
Review requested:
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
aduh95
approved these changes
Nov 2, 2022
Trott
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Nov 2, 2022
richardlau
approved these changes
Nov 2, 2022
legendecas
approved these changes
Nov 3, 2022
anonrig
approved these changes
Nov 3, 2022
gireeshpunathil
approved these changes
Nov 3, 2022
aduh95
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 3, 2022
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 3, 2022
Landed in 1af63a9 |
lucshi
pushed a commit
to lucshi/node
that referenced
this pull request
Nov 9, 2022
The name has been changed from nodejs-dev to nodejs-core. PR-URL: nodejs#45293 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
The name has been changed from nodejs-dev to nodejs-core. PR-URL: #45293 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
The name has been changed from nodejs-dev to nodejs-core. PR-URL: #45293 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
The name has been changed from nodejs-dev to nodejs-core. PR-URL: #45293 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
The name has been changed from nodejs-dev to nodejs-core. PR-URL: #45293 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name has been changed from nodejs-dev to nodejs-core.