deps: patch V8 to 10.7.193.22 #45460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
added
dont-land-on-v14.x
dont-land-on-v18.x
|
Review requested:
|
nodejs-github-bot
added
needs-ci
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
aduh95
approved these changes
Nov 14, 2022
|
@targos What is your timeline/thoughts for upgrading v8 11? |
|
You'll need to rebase against the main branch to pick up the fix for the lint issue. |
gengjiawen
approved these changes
Nov 15, 2022
targos
force-pushed
the
v8-10.7.193.22
branch
from
c23a1d2
to
8fdd5fc
Compare
|
Rebased |
|
@anonrig Whenever it's ready. Note that there's nothing special to expect with V8 11.0 compared to other versions. V8 version numbers don't follow semver, they follow the Chromium schedule. |
github-actions
bot
removed
the
request-ci
You can try latest v8 bundled in node in https://github.com/nodejs/node-v8/tree/canary. |
anonrig
approved these changes
Nov 15, 2022
targos
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 8f9dc27 |
This was referenced Nov 20, 2022
ruyadorno
pushed a commit
that referenced
this pull request
Nov 21, 2022
Refs: v8/v8@10.7.193.20...10.7.193.22 PR-URL: #45460 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: v8/v8@10.7.193.20...10.7.193.22