-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
events: fix violation of symbol naming convention #45978
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
deokjinkim:221226_fix_symbol_name_event
Jan 1, 2023
Merged
events: fix violation of symbol naming convention #45978
nodejs-github-bot
merged 1 commit into
nodejs:main
from
deokjinkim:221226_fix_symbol_name_event
Jan 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Capital letter is followed after 'k' prefix.
addaleax
approved these changes
Dec 26, 2022
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Dec 26, 2022
lpinca
approved these changes
Dec 26, 2022
cjihrig
approved these changes
Dec 28, 2022
JungMinu
approved these changes
Dec 28, 2022
aduh95
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Dec 28, 2022
targos
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jan 1, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jan 1, 2023
Landed in 91b9a47 |
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 2, 2023
Capital letter is followed after 'k' prefix. PR-URL: #45978 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 4, 2023
Capital letter is followed after 'k' prefix. PR-URL: #45978 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 5, 2023
Capital letter is followed after 'k' prefix. PR-URL: #45978 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
Capital letter is followed after 'k' prefix. PR-URL: #45978 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 31, 2023
Capital letter is followed after 'k' prefix. PR-URL: #45978 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capital letter is followed after 'k' prefix.