esm: mark `importAssertions` as required #46164

aduh95 · 2023-01-10T20:52:50Z

We already always specify a value, and failing to do so would likely be a bug.

nodejs-github-bot · 2023-01-10T20:52:55Z

Review requested:

@nodejs/loaders
@nodejs/modules

JakobJingleheimer

I'm not sure neglecting to provide a value is a bug, but happy to be corrected. Could you provide some rationale as to how/why it might be?

lib/internal/modules/esm/loader.js

aduh95 · 2023-01-10T22:31:00Z

I'm not sure neglecting to provide a value is a bug, but happy to be corrected. Could you provide some rationale as to how/why it might be?

V8 always provides an object that represents the import assertions for a specific import, so if the value is ever undefined, that means we probably forgot to pass the value from V8 to the loader, and that would be clearly a bug. Let me return the question: in what scenario would it be OK to call this function with only two parameters instead of three?

lib/internal/modules/esm/loader.js

JakobJingleheimer · 2023-01-10T22:45:18Z

V8 always provides an object that represents the import assertions for a specific import, so if the value is ever undefined, that means we probably forgot to pass the value from V8 to the loader, and that would be clearly a bug.

Ah, maybe yes 🤔

Let me return the question: in what scenario would it be OK to call this function with only two parameters instead of three?

I don't know of a specific scenario; I think likely never. The optional param is a convenience.

aduh95 · 2023-01-10T22:47:56Z

The optional param is a convenience.

In this case, I think it's more of a footgun than a convenience.

GeoffreyBooth

Discussed in #46153 (review)

nodejs-github-bot · 2023-01-10T23:44:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/48933/

nodejs-github-bot · 2023-01-11T10:27:55Z

CI: https://ci.nodejs.org/job/node-test-pull-request/48935/

nodejs-github-bot · 2023-01-11T16:26:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/48947/

nodejs-github-bot · 2023-01-12T12:56:16Z

CI: https://ci.nodejs.org/job/node-test-pull-request/48954/

nodejs-github-bot · 2023-01-12T21:02:09Z

Commit Queue failed

- Loading data for nodejs/node/pull/46164 ✔ Done loading data for nodejs/node/pull/46164 ----------------------------------- PR info ------------------------------------ Title esm: mark `importAssertions` as required (#46164) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:import-assertions-required -> nodejs:main Labels esm, author ready, needs-ci Commits 4 - esm: mark `importAssertions` as required - Apply suggestions from code review - Update lib/internal/modules/esm/loader.js - Update lib/internal/modules/esm/loader.js Committers 2 - Antoine du Hamel - GitHub PR-URL: https://github.com/nodejs/node/pull/46164 Reviewed-By: Geoffrey Booth Reviewed-By: Michaël Zasso ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46164 Reviewed-By: Geoffrey Booth Reviewed-By: Michaël Zasso -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 10 Jan 2023 20:52:50 GMT ✔ Approvals: 2 ✔ - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/46164#pullrequestreview-1243081831 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/46164#pullrequestreview-1243560207 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-01-12T12:56:16Z: https://ci.nodejs.org/job/node-test-pull-request/48954/ - Querying data for job/node-test-pull-request/48954/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 46164 From https://github.com/nodejs/node * branch refs/pull/46164/merge -> FETCH_HEAD ✔ Fetched commits as 91ca2d404192..cd7f6e652d81 -------------------------------------------------------------------------------- Auto-merging lib/internal/modules/esm/loader.js [main 26c2ef0f51] esm: mark `importAssertions` as required Author: Antoine du Hamel Date: Tue Jan 10 21:47:00 2023 +0100 1 file changed, 4 insertions(+), 12 deletions(-) Auto-merging lib/internal/modules/esm/loader.js [main f85caff68f] Apply suggestions from code review Author: Antoine du Hamel Date: Tue Jan 10 23:26:57 2023 +0100 1 file changed, 6 insertions(+), 2 deletions(-) Auto-merging lib/internal/modules/esm/loader.js [main fac5d98694] Update lib/internal/modules/esm/loader.js Author: Antoine du Hamel Date: Tue Jan 10 23:31:30 2023 +0100 1 file changed, 3 insertions(+), 3 deletions(-) Auto-merging lib/internal/modules/esm/loader.js [main 41bb707d5d] Update lib/internal/modules/esm/loader.js Author: Antoine du Hamel Date: Tue Jan 10 23:31:51 2023 +0100 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 4 commits in the PR. Attempting autorebase. Rebasing (2/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
esm: mark importAssertions as required

We already always specify a value, and failing to do so would likely be
a bug.

PR-URL: #46164
Reviewed-By: Geoffrey Booth webadmin@geoffreybooth.com
Reviewed-By: Michaël Zasso targos@protonmail.com

[detached HEAD b4bc551792] esm: mark importAssertions as required
Author: Antoine du Hamel duhamelantoine1995@gmail.com
Date: Tue Jan 10 21:47:00 2023 +0100
1 file changed, 4 insertions(+), 12 deletions(-)
Rebasing (3/8)
Rebasing (4/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Apply suggestions from code review

PR-URL: #46164
Reviewed-By: Geoffrey Booth webadmin@geoffreybooth.com
Reviewed-By: Michaël Zasso targos@protonmail.com

[detached HEAD ea0b8ae48a] Apply suggestions from code review
Author: Antoine du Hamel duhamelantoine1995@gmail.com
Date: Tue Jan 10 23:26:57 2023 +0100
1 file changed, 6 insertions(+), 2 deletions(-)
Rebasing (5/8)
Rebasing (6/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update lib/internal/modules/esm/loader.js

PR-URL: #46164
Reviewed-By: Geoffrey Booth webadmin@geoffreybooth.com
Reviewed-By: Michaël Zasso targos@protonmail.com

[detached HEAD 0e1df065cf] Update lib/internal/modules/esm/loader.js
Author: Antoine du Hamel duhamelantoine1995@gmail.com
Date: Tue Jan 10 23:31:30 2023 +0100
1 file changed, 3 insertions(+), 3 deletions(-)
Rebasing (7/8)
Rebasing (8/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update lib/internal/modules/esm/loader.js

PR-URL: #46164
Reviewed-By: Geoffrey Booth webadmin@geoffreybooth.com
Reviewed-By: Michaël Zasso targos@protonmail.com

[detached HEAD e0bbd50458] Update lib/internal/modules/esm/loader.js
Author: Antoine du Hamel duhamelantoine1995@gmail.com
Date: Tue Jan 10 23:31:51 2023 +0100
1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/3905995776

nodejs-github-bot · 2023-01-12T21:11:14Z

Landed in 31ea7be

We already always specify a value, and failing to do so would likely be a bug. PR-URL: nodejs#46164 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

We already always specify a value, and failing to do so would likely be a bug. PR-URL: #46164 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

esm: mark importAssertions as required

0b65872

We already always specify a value, and failing to do so would likely be a bug.

aduh95 requested a review from GeoffreyBooth January 10, 2023 20:52

nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Jan 10, 2023

aduh95 mentioned this pull request Jan 10, 2023

esm: allow resolve to optionally return import assertions #46153

Merged

JakobJingleheimer reviewed Jan 10, 2023

View reviewed changes

lib/internal/modules/esm/loader.js Outdated Show resolved Hide resolved

aduh95 commented Jan 10, 2023

View reviewed changes

lib/internal/modules/esm/loader.js Outdated Show resolved Hide resolved

Apply suggestions from code review

4c14433

aduh95 commented Jan 10, 2023

View reviewed changes

lib/internal/modules/esm/loader.js Outdated Show resolved Hide resolved

Update lib/internal/modules/esm/loader.js

8fc2ece

aduh95 commented Jan 10, 2023

View reviewed changes

lib/internal/modules/esm/loader.js Outdated Show resolved Hide resolved

Update lib/internal/modules/esm/loader.js

cd7f6e6

GeoffreyBooth approved these changes Jan 10, 2023

View reviewed changes

aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 10, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 10, 2023

targos approved these changes Jan 11, 2023

View reviewed changes

github-actions bot mentioned this pull request Jan 12, 2023

CI Reliability 2023-01-12 nodejs/reliability#481

Open

26 tasks

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 12, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 12, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 12, 2023

nodejs-github-bot merged commit 31ea7be into nodejs:main Jan 12, 2023

aduh95 deleted the import-assertions-required branch January 13, 2023 00:04

github-actions bot mentioned this pull request Jan 18, 2023

CI Reliability 2023-01-18 nodejs/reliability#487

Open

18 tasks

RafaelGSS mentioned this pull request Jan 20, 2023

v19.5.0 proposal #46286

Merged

juanarbol added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Jan 25, 2023

This comment was marked as outdated.

Sign in to view

juanarbol removed the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Jan 25, 2023

juanarbol mentioned this pull request Jan 28, 2023

V18.14.0 proposal #46396

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

esm: mark `importAssertions` as required #46164

esm: mark `importAssertions` as required #46164

aduh95 commented Jan 10, 2023

nodejs-github-bot commented Jan 10, 2023

JakobJingleheimer left a comment

aduh95 commented Jan 10, 2023

JakobJingleheimer commented Jan 10, 2023

aduh95 commented Jan 10, 2023

GeoffreyBooth left a comment

nodejs-github-bot commented Jan 10, 2023

nodejs-github-bot commented Jan 11, 2023

nodejs-github-bot commented Jan 11, 2023

nodejs-github-bot commented Jan 12, 2023

nodejs-github-bot commented Jan 12, 2023

PR-URL: #46164
Reviewed-By: Geoffrey Booth webadmin@geoffreybooth.com
Reviewed-By: Michaël Zasso targos@protonmail.com

PR-URL: #46164
Reviewed-By: Geoffrey Booth webadmin@geoffreybooth.com
Reviewed-By: Michaël Zasso targos@protonmail.com

PR-URL: #46164
Reviewed-By: Geoffrey Booth webadmin@geoffreybooth.com
Reviewed-By: Michaël Zasso targos@protonmail.com

PR-URL: #46164
Reviewed-By: Geoffrey Booth webadmin@geoffreybooth.com
Reviewed-By: Michaël Zasso targos@protonmail.com

Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented Jan 12, 2023

This comment was marked as outdated.

esm: mark importAssertions as required #46164

esm: mark importAssertions as required #46164

Conversation

aduh95 commented Jan 10, 2023

nodejs-github-bot commented Jan 10, 2023

JakobJingleheimer left a comment

Choose a reason for hiding this comment

aduh95 commented Jan 10, 2023

JakobJingleheimer commented Jan 10, 2023

aduh95 commented Jan 10, 2023

GeoffreyBooth left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Jan 10, 2023

nodejs-github-bot commented Jan 11, 2023

nodejs-github-bot commented Jan 11, 2023

nodejs-github-bot commented Jan 12, 2023

nodejs-github-bot commented Jan 12, 2023

PR-URL: #46164 Reviewed-By: Geoffrey Booth webadmin@geoffreybooth.com Reviewed-By: Michaël Zasso targos@protonmail.com

PR-URL: #46164 Reviewed-By: Geoffrey Booth webadmin@geoffreybooth.com Reviewed-By: Michaël Zasso targos@protonmail.com

PR-URL: #46164 Reviewed-By: Geoffrey Booth webadmin@geoffreybooth.com Reviewed-By: Michaël Zasso targos@protonmail.com

PR-URL: #46164 Reviewed-By: Geoffrey Booth webadmin@geoffreybooth.com Reviewed-By: Michaël Zasso targos@protonmail.com

Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented Jan 12, 2023

This comment was marked as outdated.

esm: mark `importAssertions` as required #46164

esm: mark `importAssertions` as required #46164

PR-URL: #46164
Reviewed-By: Geoffrey Booth webadmin@geoffreybooth.com
Reviewed-By: Michaël Zasso targos@protonmail.com

PR-URL: #46164
Reviewed-By: Geoffrey Booth webadmin@geoffreybooth.com
Reviewed-By: Michaël Zasso targos@protonmail.com

PR-URL: #46164
Reviewed-By: Geoffrey Booth webadmin@geoffreybooth.com
Reviewed-By: Michaël Zasso targos@protonmail.com

PR-URL: #46164
Reviewed-By: Geoffrey Booth webadmin@geoffreybooth.com
Reviewed-By: Michaël Zasso targos@protonmail.com