-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update undici to 5.16.0 #46213
Conversation
Could we rerun this workflow, in reference to #46217 |
This has relevant looking test failures for the withoutssl build. @nodejs/undici |
Where do I see those? |
Here's the first few failures:
|
@KhafraDev I think we should avoid loading WebSocket if there is no crypto, and definitely do not crash. |
323d837
to
16da87b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Landed in 19623e3 |
@mcollina FYI Unfortunately squashing the commits using the commit queue has given the squashed commit the title from the first commit: 19623e3 The commit queue works this way because the more common squash flow is that the follow up commits being squashed are fix ups. |
PR-URL: #46213 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This is an automated update of undici to 5.15.0.