Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: make some parameters optional in webstreams #46269

Merged
merged 1 commit into from
Jan 21, 2023

Conversation

deokjinkim
Copy link
Contributor

Some parameters are described as optional in spec, so update mismatched parameter.

Refs: https://streams.spec.whatwg.org/

Some parameters are described as optional in spec, so update
mismatched parameter.

Refs: https://streams.spec.whatwg.org/
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. web streams labels Jan 19, 2023
@aduh95 aduh95 changed the title doc,lib: make some parameters optional in webstreams doc: make some parameters optional in webstreams Jan 19, 2023
@aduh95 aduh95 added doc Issues and PRs related to the documentations. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Jan 19, 2023
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 20, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 21, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/46269
✔  Done loading data for nodejs/node/pull/46269
----------------------------------- PR info ------------------------------------
Title      doc: make some parameters optional in webstreams (#46269)
Author     Deokjin Kim  (@deokjinkim)
Branch     deokjinkim:230119_webstreams_make_optional -> nodejs:main
Labels     doc, author ready, web streams
Commits    1
 - doc,lib: make some parameters optional in webstreams
Committers 1
 - Deokjin Kim 
PR-URL: https://github.com/nodejs/node/pull/46269
Refs: https://streams.spec.whatwg.org/
Reviewed-By: Antoine du Hamel 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46269
Refs: https://streams.spec.whatwg.org/
Reviewed-By: Antoine du Hamel 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 19 Jan 2023 10:42:41 GMT
   ✔  Approvals: 2
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/46269#pullrequestreview-1261604583
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46269#pullrequestreview-1263226587
   ✖  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-01-20T09:40:59Z: https://ci.nodejs.org/job/node-test-pull-request/49102/
- Querying data for job/node-test-pull-request/49102/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3974461802

@aduh95 aduh95 merged commit 05296d9 into nodejs:main Jan 21, 2023
@aduh95
Copy link
Contributor

aduh95 commented Jan 21, 2023

Landed in 05296d9

ruyadorno pushed a commit that referenced this pull request Feb 1, 2023
Some parameters are described as optional in spec, so update
mismatched parameter.

Refs: https://streams.spec.whatwg.org/

PR-URL: #46269
Refs: https://streams.spec.whatwg.org/
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Feb 1, 2023
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
Some parameters are described as optional in spec, so update
mismatched parameter.

Refs: https://streams.spec.whatwg.org/

PR-URL: #46269
Refs: https://streams.spec.whatwg.org/
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@juanarbol juanarbol mentioned this pull request Mar 3, 2023
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
Some parameters are described as optional in spec, so update
mismatched parameter.

Refs: https://streams.spec.whatwg.org/

PR-URL: #46269
Refs: https://streams.spec.whatwg.org/
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@deokjinkim deokjinkim removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. web streams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants