-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchmark: add trailing commas #46370
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
assert
Issues and PRs related to the assert subsystem.
benchmark
Issues and PRs related to the benchmark subsystem.
child_process
Issues and PRs related to the child_process subsystem.
cluster
Issues and PRs related to the cluster subsystem.
dgram
Issues and PRs related to the dgram subsystem / UDP.
diagnostics_channel
Issues and PRs related to diagnostics channel
dns
Issues and PRs related to the dns subsystem.
domain
Issues and PRs related to the domain subsystem.
http
Issues or PRs related to the http subsystem.
v8 engine
Issues and PRs related to the V8 dependency.
labels
Jan 26, 2023
anonrig
approved these changes
Jan 26, 2023
aduh95
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
and removed
http
Issues or PRs related to the http subsystem.
assert
Issues and PRs related to the assert subsystem.
cluster
Issues and PRs related to the cluster subsystem.
child_process
Issues and PRs related to the child_process subsystem.
dgram
Issues and PRs related to the dgram subsystem / UDP.
dns
Issues and PRs related to the dns subsystem.
domain
Issues and PRs related to the domain subsystem.
v8 engine
Issues and PRs related to the V8 dependency.
diagnostics_channel
Issues and PRs related to diagnostics channel
labels
Jan 26, 2023
MoLow
approved these changes
Jan 26, 2023
jasnell
approved these changes
Jan 29, 2023
Landed in ca5f322 |
ruyadorno
pushed a commit
that referenced
this pull request
Feb 1, 2023
PR-URL: #46370 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Mar 3, 2023
PR-URL: #46370 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Mar 3, 2023
PR-URL: #46370 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
juanarbol
pushed a commit
that referenced
this pull request
Mar 5, 2023
PR-URL: #46370 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
benchmark
Issues and PRs related to the benchmark subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforce trailing commas in more places, and add them where they were missing in the benchmark files.