http: correctly calculate strict content length #46601
Merged
+39
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
ronag
force-pushed
the
http-byte-len
branch
8 times, most recently
from
dd09cc5
to
481ed62
Compare
ronag
added
request-ci
github-actions
bot
added
request-ci-failed
Failed to start CI- Validating Jenkins credentials ✖ Jenkins credentials invalidhttps://github.com/nodejs/node/actions/runs/4142770062 |
ShogunPanda
approved these changes
Feb 10, 2023
debadree25
reviewed
Feb 10, 2023
|
I wonder if we could also use the V8 fast calls to improve the underlying |
|
We already have an ongoing discussion regarding this over at the performance repo. |
|
Here is the link, nodejs/performance#52. |
aduh95
added
request-ci
ronag
added
request-ci
github-actions
bot
removed
the
request-ci
32 tasks
ronag
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/46601 ✔ Done loading data for nodejs/node/pull/46601 ----------------------------------- PR info ------------------------------------ Title http: correctly calculate strict content length (#46601) Author Robert Nagy (@ronag) Branch ronag:http-byte-len -> nodejs:main Labels http, author ready Commits 11 - http: correctly calculate strict content length - http: speedup strict content length - http: make sure to pass encoding to Buffer.byteLength - http: count writtenBytes even if socket is not ready - fixup! http: speedup strict content length - fixup! http: speedup strict content length - fixuP - fixuP - fixup - fixup: linting - fixup: cleanup Committers 1 - Robert Nagy PR-URL: https://github.com/nodejs/node/pull/46601 Reviewed-By: Matteo Collina Reviewed-By: Paolo Insogna Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46601 Reviewed-By: Matteo Collina Reviewed-By: Paolo Insogna Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - fixup: linting ⚠ - fixup: cleanup ℹ This PR was created on Fri, 10 Feb 2023 07:55:18 GMT ✔ Approvals: 3 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/46601#pullrequestreview-1302089257 ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/46601#pullrequestreview-1292827320 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/46601#pullrequestreview-1300561862 ✖ Last GitHub CI failed ℹ Last Full PR CI on 2023-02-17T10:01:39Z: https://ci.nodejs.org/job/node-test-pull-request/49619/ - Querying data for job/node-test-pull-request/49619/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4234920191 |
mcollina
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed{"message":"Base branch was modified. Review and try the merge again.","documentation_url":"https://docs.github.com/rest/reference/pulls#merge-a-pull-request"}https://github.com/nodejs/node/actions/runs/4251305015 |
mcollina
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 9e1824d |
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
Fixes some logical errors related to strict content length. Also, previously Buffer.byteLength (which is slow) was run regardless of whether or not the len was required. PR-URL: #46601 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
Fixes some logical errors related to strict content length. Also, previously Buffer.byteLength (which is slow) was run regardless of whether or not the len was required. PR-URL: #46601 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously Buffer.byteLength (which is slow) was run regardless of whether or not the len was required.