doc: fix myUrl is not defined in url #46968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
aduh95
approved these changes
Mar 6, 2023
aduh95
added
the
author ready
HarshithaKP
approved these changes
Mar 6, 2023
anonrig
approved these changes
Mar 6, 2023
marsonya
approved these changes
Mar 6, 2023
cjihrig
approved these changes
Mar 6, 2023
lpinca
approved these changes
Mar 6, 2023
aduh95
added
the
commit-queue
Fixes a typo in the variable name in the URL code example in doc. Renames `myUrl` to `myURL` for consistency and readability.
recrack
force-pushed
the
fix-typo-in-variable-name
branch
from
4677b43
to
06b8799
Compare
|
Following the commit message guidelines, I have updated the message to be within the 72-character limit. |
recrack
requested review from
anonrig,
cjihrig,
marsonya,
lpinca,
HarshithaKP and
aduh95
and removed request for
anonrig,
cjihrig,
marsonya,
lpinca,
HarshithaKP and
aduh95
deokjinkim
approved these changes
Mar 7, 2023
nodejs-github-bot
removed
the
commit-queue
|
Landed in c89c259 |
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
Fixes a typo in the variable name in the URL code example in doc. Renames `myUrl` to `myURL` for consistency and readability. PR-URL: #46968 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 14, 2023
Fixes a typo in the variable name in the URL code example in doc. Renames `myUrl` to `myURL` for consistency and readability. PR-URL: #46968 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
Fixes a typo in the variable name in the URL code example in doc. Renames `myUrl` to `myURL` for consistency and readability. PR-URL: #46968 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a typo in the variable name in the URL code example in doc.
Renames
myUrltomyURLfor consistency and readability.