Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quic: next iteration #48244

Closed
wants to merge 8 commits into from
Closed

quic: next iteration #48244

wants to merge 8 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented May 29, 2023

Adds the basic implementation of the quic stream. Still more to come.

@jasnell jasnell requested review from Qard, anonrig and tniessen May 29, 2023 18:21
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 29, 2023
anonrig
anonrig reviewed May 29, 2023
View reviewed changes
src/dataqueue/queue.cc Outdated Show resolved Hide resolved
src/dataqueue/queue.cc Outdated Show resolved Hide resolved
src/quic/streams.cc Show resolved Hide resolved
src/quic/streams.cc Show resolved Hide resolved
src/quic/streams.cc Show resolved Hide resolved
src/quic/streams.cc Outdated Show resolved Hide resolved
src/quic/streams.cc Outdated Show resolved Hide resolved
src/quic/streams.cc Show resolved Hide resolved
src/quic/streams.cc Outdated Show resolved Hide resolved
src/quic/streams.cc Outdated Show resolved Hide resolved
@achingbrain achingbrain mentioned this pull request May 30, 2023
Open
Qard
Qard reviewed Jun 1, 2023
View reviewed changes
src/quic/streams.cc Outdated Show resolved Hide resolved
@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. quic Issues and PRs related to the QUIC implementation / HTTP/3. dont-land-on-v16.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Jun 3, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52117/

This was referenced Jun 6, 2023
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52192/

This was referenced Jun 11, 2023
Open
Open
Open
Open
Open
This was referenced Sep 19, 2023
Open
Open
@achingbrain achingbrain mentioned this pull request Oct 1, 2023
Closed
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@anonrig anonrig added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Dec 9, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 10, 2023 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/56214/ 💚

jasnell added a commit that referenced this pull request Dec 11, 2023
@jasnell
quic: further implementation details
fc102f2 
PR-URL: #48244
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@jasnell
Copy link
Member Author

jasnell commented Dec 11, 2023

Landed in fc102f2

@jasnell jasnell closed this Dec 11, 2023
RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
@jasnell @RafaelGSS
quic: further implementation details
3fb7fc9 
PR-URL: #48244
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@RafaelGSS RafaelGSS mentioned this pull request Dec 15, 2023
Merged
@robertsLando robertsLando mentioned this pull request Aug 8, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qard Qard Qard approved these changes

@anonrig anonrig anonrig approved these changes

@tniessen tniessen Awaiting requested review from tniessen

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jasnell @nodejs-github-bot @anonrig @Qard @targos @aduh95