Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix hardwareConcurrency example #50278

Merged
merged 1 commit into from
Oct 23, 2023
Merged

doc: fix hardwareConcurrency example #50278

merged 1 commit into from
Oct 23, 2023

Conversation

tniessen
Copy link
Member

Refs: #47769

@tniessen tniessen added doc Issues and PRs related to the documentations. experimental Issues and PRs related to experimental features. labels Oct 19, 2023
@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 19, 2023
@H4ad H4ad added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55005/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55017/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55018/

Uzlopak
Uzlopak approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tniessen
Copy link
Member Author

@H4ad This PR did not need a Jenkins CI run because it touches documentation only.

@H4ad
Copy link
Member

H4ad commented Oct 19, 2023 •
edited
Loading

@tniessen Oh, thanks for letting me know.

In cases like this, should we just fast-track or there is another behavior?

@tniessen
Copy link
Member Author

tniessen commented Oct 19, 2023 •
edited
Loading

In cases like this, should we just fast-track or there is another behavior?

Any collaborator may suggest fast-tracking of such small doc-only changes by adding the fast-track label. But it's perfectly reasonable for a PR like this to wait for two days to land (without Jenkins CI) since it's not urgent by any means.

IIRC, now that Jenkins CI has been started, we have to run it until it passes for the commit queue to not reject the PR, but perhaps I am misremembering or things have changed.

This was referenced Oct 20, 2023
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55113/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55121/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55122/

@tniessen
Copy link
Member Author

Not sure what's going on with ARM...

@github-actions github-actions bot mentioned this pull request Oct 23, 2023
Open
26 tasks
@aduh95 aduh95 merged commit fa514c9 into nodejs:main Oct 23, 2023
51 of 54 checks passed
@aduh95
Copy link
Contributor

aduh95 commented Oct 23, 2023

Landed in 5d33203

@github-actions github-actions bot mentioned this pull request Oct 24, 2023
Open
27 tasks
targos pushed a commit that referenced this pull request Oct 24, 2023
@tniessen @targos
doc: fix navigator.hardwareConcurrency example
db2a1cf 
PR-URL: #50278
Refs: #47769
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Oct 24, 2023
Merged
@github-actions github-actions bot mentioned this pull request Oct 25, 2023
Open
16 tasks
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@tniessen @alexfernandez
doc: fix navigator.hardwareConcurrency example
fae8503 
PR-URL: nodejs#50278
Refs: nodejs#47769
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos added dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@targos targos targos approved these changes

@Uzlopak Uzlopak Uzlopak approved these changes

@richardlau richardlau richardlau approved these changes

@H4ad H4ad H4ad approved these changes

@aymen94 aymen94 aymen94 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. experimental Issues and PRs related to experimental features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@tniessen @nodejs-github-bot @H4ad @aduh95 @lpinca @anonrig @targos @Uzlopak @richardlau @aymen94