Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: fix glob returning duplicates #50881

Merged
merged 1 commit into from
Nov 26, 2023
Merged

fs: fix glob returning duplicates #50881

merged 1 commit into from
Nov 26, 2023

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Nov 23, 2023

Fixes: #50875

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Nov 23, 2023
@MoLow
Copy link
Member Author

MoLow commented Nov 23, 2023

CC @isaacs kindly, PTAL

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 24, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55900/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55924/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55925/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55926/

@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 26, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 26, 2023
@nodejs-github-bot nodejs-github-bot merged commit f28839b into nodejs:main Nov 26, 2023
63 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f28839b

martenrichter pushed a commit to martenrichter/node that referenced this pull request Nov 26, 2023
@MoLow @martenrichter
fs: fix glob returning duplicates
728e27d 
PR-URL: nodejs#50881
Fixes: nodejs#50875
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@MoLow @lucshi
fs: fix glob returning duplicates
e9c4813 
PR-URL: nodejs#50881
Fixes: nodejs#50875
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Nov 27, 2023
@MoLow @RafaelGSS
fs: fix glob returning duplicates
1bf0d8d 
PR-URL: #50881
Fixes: #50875
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@MoLow @RafaelGSS
fs: fix glob returning duplicates
e4e0add 
PR-URL: #50881
Fixes: #50875
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Nov 30, 2023
@MoLow @RafaelGSS
fs: fix glob returning duplicates
941248b 
PR-URL: #50881
Fixes: #50875
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@richardlau richardlau added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Mar 25, 2024
@MoLow MoLow deleted the fix-duplicate-glob branch May 24, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@anonrig anonrig anonrig approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Node v21] node --test executes tests twice if they are in folder named test
6 participants
@MoLow @nodejs-github-bot @benjamingr @anonrig @aduh95 @richardlau