Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build, tools: copy release assets to staging R2 bucket once built #51394

Merged
merged 1 commit into from
May 6, 2024
Merged

build, tools: copy release assets to staging R2 bucket once built #51394

merged 1 commit into from
May 6, 2024
+60 −1

Conversation

flakey5
Copy link
Member

@flakey5 flakey5 commented Jan 6, 2024 •
edited
Loading

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels Jan 6, 2024
@flakey5
Copy link
Member Author

flakey5 commented Jan 6, 2024

Background: nodejs/build#3602

@flakey5 flakey5 mentioned this pull request Jan 6, 2024
Closed
4 tasks
targos
targos reviewed Jan 7, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
targos
targos reviewed Jan 8, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
targos
targos reviewed Jan 8, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
targos
targos reviewed Jan 8, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
targos
targos reviewed Jan 8, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
targos
targos reviewed Jan 8, 2024
View reviewed changes
vcbuild.bat Outdated Show resolved Hide resolved
targos
targos reviewed Jan 11, 2024
View reviewed changes
vcbuild.bat Outdated Show resolved Hide resolved
targos
targos reviewed Jan 18, 2024
View reviewed changes
vcbuild.bat Outdated Show resolved Hide resolved
@flakey5 flakey5 force-pushed the flakey5/nodejs/build/3602 branch 2 times, most recently from 85f98db to 87d2b3c Compare January 19, 2024 20:42
@targos
Copy link
Member

targos commented Jan 21, 2024

I did a test release build (https://ci-release.nodejs.org/job/iojs+release/9917/ for those who have access), but it failed to upload:

09:07:10 ssh node-www "aws s3 cp nodejs/custom/v22.0.0-test2024012187d2b3c18f/node-v22.0.0-test2024012187d2b3c18f-linux-x64.tar.gz s3://dist-staging/nodejs/custom/v22.0.0-test2024012187d2b3c18f/node-v22.0.0-test2024012187d2b3c18f-linux-x64.tar.gz --endpoint=https://07be8d2fbc940503ca1be344714cb0d1.r2.cloudflarestorage.com/" --profile=nodejs-r2-dist-bucket
09:07:12 
09:07:12 The config profile (nodejs-r2-dist-bucket) could not be found
09:07:12 make: *** [Makefile:1291: binary-upload] Error 255

@flakey5
Copy link
Member Author

flakey5 commented Jan 22, 2024 •
edited
Loading

I did a test release build (https://ci-release.nodejs.org/job/iojs+release/9917/ for those who have access), but it failed to upload:

Should be the correct profile now (or at least this is the profile used here https://github.com/nodejs/build/blob/a721695e2b652bee056502e5c7da3ec03d1ca150/ansible/www-standalone/tools/promote/settings#L41)

@targos
Copy link
Member

targos commented Jan 23, 2024

New build: https://ci-release.nodejs.org/job/iojs+release/9924/

@targos
Copy link
Member

targos commented Jan 23, 2024

It looks much better:

CleanShot 2024-01-23 at 09 31 55

There are a few failures, but I'll report them all when the job is finished.

@targos
Copy link
Member

targos commented Jan 23, 2024

On Windows (all three builds):

upload: nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae-arm64.msi to s3://dist-staging/nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae-arm64.msi
09:47:52 touch: cannot touch 's3://dist-staging/nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae-win-arm64.zip.done': No such file or directory

upload: nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae-x64.msi to s3://dist-staging/nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae-x64.msi
09:17:15 touch: cannot touch 's3://dist-staging/nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae-win-x64.zip.done': No such file or directory

upload: nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae-x86.msi to s3://dist-staging/nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae-x86.msi
09:19:02 touch: cannot touch 's3://dist-staging/nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae-win-x86.zip.done': No such file or directory

On macOS (osx11-release-pkg)

09:33:01 scp -p node-v22.0.0-test20240123a1b77670ae.pkg node-www:nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae.pkg
09:33:06 ssh node-www "aws s3 cp nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae.pkg s3://dist-staging/nodejs/custom/v22.0.0-test20240123a1b77670ae/node-v22.0.0-test20240123a1b77670ae.pkg --endpoint=https://07be8d2fbc940503ca1be344714cb0d1.r2.cloudflarestorage.com/" --profile=worker"
09:33:06 /bin/sh: -c: line 0: unexpected EOF while looking for matching `"'
09:33:06 /bin/sh: -c: line 1: syntax error: unexpected end of file
09:33:06 make: *** [pkg-upload] Error 2

targos
targos reviewed Jan 24, 2024
View reviewed changes
vcbuild.bat Show resolved Hide resolved
@targos
Copy link
Member

targos commented Jan 24, 2024

please review each new line in the Makefile. The double quotes are not placed correctly.

targos
targos reviewed Jan 26, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2024
@targos targos removed the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2024
@targos
Copy link
Member

targos commented May 5, 2024

I want to land #45427 first as it's building a whole new ccache.

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58959/

@targos
Copy link
Member

targos commented May 5, 2024

@flakey5 Can you please rebase on the latest main? It seems that the CI wrongly sets the major version as 22 instead of 23.

@flakey5 flakey5 force-pushed the flakey5/nodejs/build/3602 branch from 7121813 to 33c6584 Compare May 5, 2024 22:29
@flakey5
Copy link
Member Author

flakey5 commented May 5, 2024

Done

@flakey5 @targos
build, tools: copy release assets to staging R2 bucket once built
2ee2b5f 
Co-authored-by: Michaël Zasso <targos@protonmail.com>
@flakey5 flakey5 force-pushed the flakey5/nodejs/build/3602 branch from 33c6584 to 2ee2b5f Compare May 5, 2024 23:13
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58974/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58975/

@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label May 6, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 6, 2024
@nodejs-github-bot nodejs-github-bot merged commit e5a76f1 into nodejs:main May 6, 2024
56 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in e5a76f1

flakey5 added a commit to flakey5/nodejs-build that referenced this pull request May 6, 2024
@flakey5
ansible: promote release assets from staging r2 bucket
84fccff 
Note: nodejs/node#51394 should land before this does

Reference nodejs#3602
Ch3nYuY pushed a commit to Ch3nYuY/node that referenced this pull request May 8, 2024
@flakey5 @targos @Ch3nYuY
build, tools: copy release assets to staging R2 bucket once built
4353e5b 
Co-authored-by: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs#51394
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos added a commit that referenced this pull request May 8, 2024
@flakey5 @targos
build, tools: copy release assets to staging R2 bucket once built
18c530f 
Co-authored-by: Michaël Zasso <targos@protonmail.com>
PR-URL: #51394
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos targos mentioned this pull request May 13, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@flakey5 @targos @marco-ippolito
build, tools: copy release assets to staging R2 bucket once built
5215b6f 
Co-authored-by: Michaël Zasso <targos@protonmail.com>
PR-URL: #51394
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Jun 17, 2024
Merged
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
@flakey5 @targos @eliphazbouye
build, tools: copy release assets to staging R2 bucket once built
dce10a2 
Co-authored-by: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs#51394
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@flakey5 @targos @bmeck
build, tools: copy release assets to staging R2 bucket once built
4f42f78 
Co-authored-by: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs#51394
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@aduh95 aduh95 added the lts-watch-v18.x PRs that may need to be released in v18.x. label Nov 13, 2024
@aduh95 aduh95 mentioned this pull request Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoLow MoLow MoLow approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. lts-watch-v18.x PRs that may need to be released in v18.x. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@flakey5 @targos @nodejs-github-bot @mcollina @jasnell @MoLow @aduh95