doc: only apply content-visibility on all.html #53510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
aduh95
approved these changes
Jun 19, 2024
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
panva
added
commit-queue-squash
MoLow
approved these changes
Jun 19, 2024
|
Fast-track has been requested by @MoLow. Please 👍 to approve. |
|
I suggest we get this out as fast as possible @nodejs/releasers |
|
Feel free to fast-track this. Also indeed, releases if this could be patched on current live API docs (cc @nodejs/build) |
ovflowd
approved these changes
Jun 19, 2024
This cannot be patched on the current docs and would need new releases. |
panva
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 67c19c2 |
eliphazbouye
pushed a commit
to eliphazbouye/node
that referenced
this pull request
Jun 20, 2024
Refs: nodejs#40099 PR-URL: nodejs#53510 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Claudio Wunder <cwunder@gnome.org>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
Refs: nodejs#40099 PR-URL: nodejs#53510 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #40099 (comment)
content-visibilityis the source of bad anchor scrolling behaviours in select browsers that support this rule. This change makes it only apply to the sections in theall.htmldocs page.