src: use starts_with in node_dotenv.cc
#53539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
added
dont-land-on-v18.x
nodejs-github-bot
added
c++
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
Jun 22, 2024
anonrig
added
the
author ready
|
cc @nodejs/cpp-reviewers |
H4ad
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/53539 ✔ Done loading data for nodejs/node/pull/53539 ----------------------------------- PR info ------------------------------------ Title src: use `starts_with` in node_dotenv.cc (#53539) Author Yagiz Nizipli (@anonrig) Branch anonrig:use-cpp-20-dotenv -> nodejs:main Labels c++, author ready, needs-ci, dont-land-on-v18.x, dont-land-on-v20.x Commits 1 - src: use `starts_with` in node_dotenv.cc Committers 1 - Yagiz Nizipli PR-URL: https://github.com/nodejs/node/pull/53539 Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53539 Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 21 Jun 2024 20:42:31 GMT ✔ Approvals: 1 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/53539#pullrequestreview-2133834730 ✘ This PR needs to wait 93 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-06-22T01:42:37Z: https://ci.nodejs.org/job/node-test-pull-request/59921/ - Querying data for job/node-test-pull-request/59921/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/9653587341 |
tniessen
approved these changes
Jun 25, 2024
tniessen
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 25719b1 |
aduh95
pushed a commit
that referenced
this pull request
Jul 12, 2024
PR-URL: #53539 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
aduh95
pushed a commit
that referenced
this pull request
Jul 16, 2024
PR-URL: #53539 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request includes changes from C++20. Therefore, it can not be landed to v20 or v18.