src,lib: remove the cost of encoding parameter serialization #56047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
lib / src
anonrig
force-pushed
the
yagiz/remove-cost-of-encoding
branch
from
b01ae01 to
db3069b
Compare
RafaelGSS
reviewed
Nov 28, 2024
anonrig
force-pushed
the
yagiz/remove-cost-of-encoding
branch
from
db3069b to
32ce431
Compare
ronag
approved these changes
Nov 28, 2024
|
Is this unfinished or not? It's not draft but on slack you wrote it's not finished? |
|
CI fails everywhere. It fails to build. |
Moork0
reviewed
Nov 28, 2024
| if (args.Length() >= 1) { | ||
| encoding = ParseEncoding(env->isolate(), args[0], BUFFER); | ||
| static_cast<ENCODING>(args[0].As<v8::Uint32>()->Value()); |
There was a problem hiding this comment.
Seems this line is not doing anything?
Suggested change
| static_cast<ENCODING>(args[0].As<v8::Uint32>()->Value()); | |
| encoding = static_cast<ENCODING>(args[0].As<v8::Uint32>()->Value()); |
I guess you wanted it to be like this ^ ?
Moork0
reviewed
Nov 28, 2024
| @@ -1385,7 +1385,7 @@ static void ReadLink(const FunctionCallbackInfo<Value>& args) { | |||
| THROW_IF_INSUFFICIENT_PERMISSIONS( | |||
| env, permission::PermissionScope::kFileSystemRead, path.ToStringView()); | |||
|
|
|||
| const enum encoding encoding = ParseEncoding(isolate, args[1], UTF8); | |||
| auto encoding = static_cast<ENCODING>(args[1].As<v8::Uint32>()->Value()); | |||
There was a problem hiding this comment.
IMHO, it's good to let this (and others in this file) remain const
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to remove the ability to send string encoding values (such as "utf8", "latin1" etc.) to C++. Result of this work will enable adding more V8 fast APIs and improve the performance of all functions (small or big it doesn't matter) that use encoding as a parameter.
PS: I did a similar work on Cloudflare workers: cloudflare/workerd#2478
cc @nodejs/performance @lemire @jasnell @mcollina @ronag