Skip to content

http: use cached '1.1' http version string #59717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2025
Merged

http: use cached '1.1' http version string #59717

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6006055
http: use cached '1.1' http version string
ronag Sep 2, 2025
f3be553
Update lib/_http_common.js
ronag Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/_http_common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ function parserOnHeaders(headers, url) {
this._url += url;
}

const HTTP_VERSION_1_1 = '1.1';

// `headers` and `url` are set only if .onHeaders() has not been called for
// this request.
// `url` is not set for response parsers but that's not applicable here since
Expand Down Expand Up @@ -91,7 +93,9 @@ function parserOnHeadersComplete(versionMajor, versionMinor, headers, method,
const incoming = parser.incoming = new ParserIncomingMessage(socket);
incoming.httpVersionMajor = versionMajor;
incoming.httpVersionMinor = versionMinor;
incoming.httpVersion = `${versionMajor}.${versionMinor}`;
incoming.httpVersion = versionMajor === 1 && versionMinor === 1 ?
HTTP_VERSION_1_1 :
`${versionMajor}.${versionMinor}`;
incoming.joinDuplicateHeaders = socket?.server?.joinDuplicateHeaders ||
parser.joinDuplicateHeaders;
incoming.url = url;
Expand Down
Loading