New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: get rid of sneaky hard tabs in CHANGELOG #6608

Merged
merged 1 commit into from May 6, 2016

Conversation

Projects
None yet
5 participants
@MylesBorins
Member

MylesBorins commented May 6, 2016

Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

My editor did something strange. Sorry about that

@MylesBorins MylesBorins added the doc label May 6, 2016

@cjihrig

This comment has been minimized.

Contributor

cjihrig commented May 6, 2016

LGTM

doc: get rid of sneaky hard tabs in CHANGELOG
My editor did something strange. Sorry about that

PR-URL: #6608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@MylesBorins MylesBorins force-pushed the hard-tabs branch to 2bceda6 May 6, 2016

@MylesBorins

This comment has been minimized.

Member

MylesBorins commented May 6, 2016

landed in 2bceda6

@MylesBorins MylesBorins closed this May 6, 2016

@MylesBorins MylesBorins merged commit 2bceda6 into master May 6, 2016

@MylesBorins MylesBorins deleted the hard-tabs branch May 6, 2016

MylesBorins added a commit that referenced this pull request May 6, 2016

doc: get rid of sneaky hard tabs in CHANGELOG
My editor did something strange. Sorry about that

PR-URL: #6608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@evanlucas

This comment has been minimized.

Member

evanlucas commented May 17, 2016

Marking dont-land-on-v6x since it relies on changelogs for v5 and v4 (which we aren't backporting). If this is not the case, please let me know @thealphanerd. Thanks!

@jasnell

This comment has been minimized.

Member

jasnell commented May 17, 2016

I'll likely be backporting the changelog updates this week to v5 and v4, just haven't had much opportunity to do so yet.

@evanlucas

This comment has been minimized.

Member

evanlucas commented May 17, 2016

@jasnell ok cool. So am I still good to hold off on this?

@jasnell

This comment has been minimized.

Member

jasnell commented May 17, 2016

Yeah, I would for now but let's not forget about it.

MylesBorins added a commit that referenced this pull request May 18, 2016

doc: get rid of sneaky hard tabs in CHANGELOG
My editor did something strange. Sorry about that

PR-URL: #6608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@MylesBorins MylesBorins referenced this pull request May 18, 2016

Merged

v4.4.5 proposal #6824

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment