New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns: name anonymous functions #9052

Closed
wants to merge 1 commit into
base: master
from

Conversation

@maasencioh
Contributor

maasencioh commented Oct 12, 2016

Checklist
  • commit message follows commit guidelines
Description of change

Ref: #8913

@maasencioh maasencioh force-pushed the maasencioh:name_dns branch to 0f5a385 Oct 12, 2016

@evanlucas

This comment has been minimized.

Member

evanlucas commented Oct 12, 2016

Thanks for the contribution @maasencioh! I went ahead and started a CI run: https://ci.nodejs.org/job/node-test-pull-request/4487/

@evanlucas

LGTM

@maasencioh

This comment has been minimized.

Contributor

maasencioh commented Oct 12, 2016

Thanks @evanlucas!, freebsd it's not passing but I don't think that is related with my change

@targos

targos approved these changes Oct 12, 2016

LGTM

@fhinkel

LGTM

@jasnell

LGTM

@lpinca

lpinca approved these changes Oct 14, 2016

LGTM

@lpinca

This comment has been minimized.

Member

lpinca commented Oct 16, 2016

I've triggered another CI, just in case: https://ci.nodejs.org/job/node-test-pull-request/4534/

@jasnell jasnell self-assigned this Oct 17, 2016

jasnell added a commit that referenced this pull request Oct 17, 2016

dns: name anonymous functions
Ref: #8913
PR-URL: #9052
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell

This comment has been minimized.

Member

jasnell commented Oct 17, 2016

Landed in 115bb04

@jasnell jasnell closed this Oct 17, 2016

jasnell added a commit that referenced this pull request Oct 17, 2016

dns: name anonymous functions
Ref: #8913
PR-URL: #9052
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@maasencioh maasencioh deleted the maasencioh:name_dns branch Oct 17, 2016

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment