New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enable node-module-version/test.js with debug #9093

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
9 participants
@danbev
Member

danbev commented Oct 14, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test:

Description of change

Commit fdca79f ("test: enable addons
test to pass with debug build") enabled the addons tests to pass when
the build type is of type debug (configure --debug).

test/addons/node-module-version/test.js was recently added and expects
the the build type to be of type Release (like most of the others until
recently). This commit allows this test to pass when the build type if
of type debug.

test: enable node-module-version/test.js with debug
Commit fdca79f ("test: enable addons
test to pass with debug build") enabled the addons tests to pass when
the build type is of type debug (configure --debug).

test/addons/node-module-version/test.js was recently added and expects
the the build type to be of type Release (like most of the others until
recently). This commit allows this test to pass when the build type if
of type debug.
@santigimeno

LGTM

@danbev

This comment has been minimized.

@mscdex mscdex added the addons label Oct 14, 2016

@jasnell

LGTM

@lpinca

lpinca approved these changes Oct 14, 2016

LGTM

danbev added a commit to danbev/node that referenced this pull request Oct 17, 2016

test: enable node-module-version/test.js with debug
Commit fdca79f ("test: enable addons
test to pass with debug build") enabled the addons tests to pass when
the build type is of type debug (configure --debug).

test/addons/node-module-version/test.js was recently added and expects
the the build type to be of type Release (like most of the others until
recently). This commit allows this test to pass when the build type if
of type debug.

PR-URL: nodejs#9093
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danbev

This comment has been minimized.

Member

danbev commented Oct 17, 2016

Landed in: 9bb250b

@danbev danbev closed this Oct 17, 2016

jasnell added a commit that referenced this pull request Oct 17, 2016

test: enable node-module-version/test.js with debug
Commit fdca79f ("test: enable addons
test to pass with debug build") enabled the addons tests to pass when
the build type is of type debug (configure --debug).

test/addons/node-module-version/test.js was recently added and expects
the the build type to be of type Release (like most of the others until
recently). This commit allows this test to pass when the build type if
of type debug.

PR-URL: #9093
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins

This comment has been minimized.

Member

MylesBorins commented Nov 11, 2016

The file modified here does not exist on v4.x or v6.x. I've appropriately added do not land labels. Let me know if this is backportable

@danbev danbev deleted the danbev:fix-addons-node-module-version-test branch Jan 17, 2017

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment