Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

(deleted) Enforce types checking #1212

Closed
wants to merge 8 commits into from
Closed

(deleted) Enforce types checking #1212

wants to merge 8 commits into from

Conversation

rodion-arr
Copy link
Contributor

Description

Hi Team!

I found that types was not checked as part of lint job and there was quite a few places that was violating existed interfaces.

So this PR is some kind of proposal to enable strict types checking in the project. Anyway why we use Typescript without this? :)

In scope:

  • Added type-check npm script along with linter
  • Added storybook pages to type checking scope
  • Added few missed @types packages
  • Fixed existing interface violations
  • Added tests for updated components

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2021

Codecov Report

Merging #1212 (da98aa2) into master (ef65765) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1212      +/-   ##
==========================================
+ Coverage   57.96%   58.13%   +0.17%     
==========================================
  Files          60       60              
  Lines         716      719       +3     
  Branches      216      217       +1     
==========================================
+ Hits          415      418       +3     
  Misses        294      294              
  Partials        7        7              
Impacted Files Coverage Δ
src/components/Article/index.tsx 100.00% <100.00%> (ø)
src/hooks/useMediaQuery.tsx 54.54% <100.00%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef65765...da98aa2. Read the comment docs.

@rodion-arr rodion-arr closed this Apr 24, 2021
@rodion-arr rodion-arr changed the title Enforce types checking (deleted) Enforce types checking Apr 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants