Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switchable banner/notification/alert about important security upgrades #17

Closed
fhemberger opened this issue Jul 3, 2015 · 2 comments · Fixed by #56
Closed

Switchable banner/notification/alert about important security upgrades #17

fhemberger opened this issue Jul 3, 2015 · 2 comments · Fixed by #56
Labels
good first issue Issues for newcomers

Comments

@fhemberger
Copy link
Contributor

Reminder based on nodejs/iojs.org#397
@fhemberger fhemberger added the good first issue Issues for newcomers label Aug 28, 2015
@hoxoa
Copy link
Contributor

hoxoa commented Aug 28, 2015

@fhemberger I have a working version. Will make a PR for it.

Just a few things I noticed,

  • shouldn't the css from index.hbs go to the css (.styl)
  • the same with the css in download.hbs and add the picture to the images folder instead of hardcoding
  • why is the mac version hardcoded on the index, maybe a bit strange if you click download on a linux os.

@fhemberger
Copy link
Contributor Author

@hoxoa Yes, all styles are supposed to be in the .styl files, also the hard coding of the Mac version was just a mishap. /cc @mikeal

hoxoa added a commit to hoxoa/new.nodejs.org that referenced this issue Aug 28, 2015
@hoxoa
Switchable banner/notification/alert about important security upgrades
2411319 
closes nodejs#17
@hoxoa hoxoa mentioned this issue Aug 28, 2015
Merged
@snyk-bot snyk-bot mentioned this issue Mar 27, 2020
Open
@snyk-bot snyk-bot mentioned this issue Jul 9, 2020
Open
This was referenced Aug 9, 2020
Open
Open
@snyk-bot snyk-bot mentioned this issue Aug 27, 2020
Open
@snyk-bot snyk-bot mentioned this issue Oct 19, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switchable banner/notification/alert about important security upgrades hoxoa/new.nodejs.org
2 participants
@fhemberger @hoxoa